Skip to content
This repository was archived by the owner on Nov 4, 2021. It is now read-only.

Add url as a library - #457

Merged
Twixes merged 1 commit into
masterfrom
add-url
Jun 3, 2021
Merged

Add url as a library#457
Twixes merged 1 commit into
masterfrom
add-url

Conversation

@macobo

@macobo macobo commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

We can do some url-based analysis/changes based on this.

Checklist

  • Updated Settings section in README.md, if settings are affected
  • Jest tests

We can do some url-based analysis/changes based on this.
@macobo
macobo requested a review from yakkomajuri June 3, 2021 11:34
@Twixes Twixes added the bump patch Bump patch version when this PR gets merged label Jun 3, 2021
@Twixes
Twixes merged commit 52bb4f7 into master Jun 3, 2021
@Twixes
Twixes deleted the add-url branch June 3, 2021 11:47
@mariusandra

Copy link
Copy Markdown
Collaborator

Could we also add url to package.json to explicitly pin it to a version? It's now installed randomly by aws-sdk and that could drop on any upgrade.

@Twixes

Twixes commented Jun 3, 2021

Copy link
Copy Markdown
Member

As far as I understand this is the Node url module, is it not? url from npm is a polyfill for browsers.

@macobo

macobo commented Jun 3, 2021

Copy link
Copy Markdown
Contributor Author

AFAIK, that was my own takeaway as well based on https://nodejs.org/api/url.html

@mariusandra

Copy link
Copy Markdown
Collaborator

Ah, then please ignore me :)

fuziontech pushed a commit to PostHog/posthog that referenced this pull request Oct 12, 2021
We can do some url-based analysis/changes based on this.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bump patch Bump patch version when this PR gets merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants