test(ai): cover nested config mutation in the cache-pollution test - #802
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "test(ai): cover nested config mutation i..." | Re-trigger Greptile |
marandaneto
approved these changes
Jul 30, 2026
Contributor
posthog-python Compliance ReportDate: 2026-07-30 13:05:30 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Member
|
@jurajmajerik https://github.com/PostHog/posthog-python/actions/runs/30528065883/job/90826261323?pr=801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Follow-up to #801, mirroring a review suggestion from PostHog/posthog-js#4329. The cache-pollution test only mutated top-level config values, so swapping
copy.deepcopyfor a shallow.copy()would pass the test while quietly sharing nested objects (tools, schemas) with the cache. The test now also mutates a nested value, so that swap fails the test.💚 How did you test it?
test_prompts.py, 68 tests green. Test-only change, no changeset needed.📝 Checklist
If releasing new changes
sampo addto generate a changeset file (test-only, no release)🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code authored this under my direction as the Python mirror of the test hardening suggested on the JS PR.