fix(funnels): Improve "Time to convert" behavior - #12474
Merged
Merged
Conversation
mariusandra
approved these changes
Oct 28, 2022
mariusandra
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, yet a test is failing and I don't have enough context to verify the query 🤔
neilkakkar
approved these changes
Nov 1, 2022
neilkakkar
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nice work!
mariusandra
pushed a commit
that referenced
this pull request
Nov 2, 2022
* fix(funnels): Improve "Time to convert" behavior * Update test_insight_funnels.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When investigating #12460, I noticed "Time to convert" doesn't handle the case with zero conversion well either:
Changes
There's no NaNNaN anymore:
Also removed special handling from #5283, as it seems the ClickHouse bug got fixed. Let me know if this is correct @neilkakkar.