Skip to content

Fix Funnel Trends Persons with month/week granularity - #5277

Merged
neilkakkar merged 3 commits into
masterfrom
trends-fix-persons
Jul 22, 2021
Merged

Fix Funnel Trends Persons with month/week granularity#5277
neilkakkar merged 3 commits into
masterfrom
trends-fix-persons

Conversation

@neilkakkar

Copy link
Copy Markdown
Contributor

Changes

resolve #5275

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar
neilkakkar requested review from EDsCODE and macobo July 22, 2021 10:04
@timgl
timgl temporarily deployed to posthog-pr-5277 July 22, 2021 10:05 Inactive
Comment thread ee/clickhouse/queries/funnels/funnel_trends.py Outdated
Comment thread ee/clickhouse/queries/funnels/test/test_funnel_trends.py Outdated
@timgl
timgl temporarily deployed to posthog-pr-5277 July 22, 2021 10:19 Inactive
Comment thread ee/clickhouse/queries/funnels/funnel_trends.py Outdated
@timgl
timgl temporarily deployed to posthog-pr-5277 July 22, 2021 11:01 Inactive

@macobo macobo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the nit

@neilkakkar
neilkakkar enabled auto-merge (squash) July 22, 2021 11:03
@neilkakkar
neilkakkar merged commit b8c946c into master Jul 22, 2021
@neilkakkar
neilkakkar deleted the trends-fix-persons branch July 22, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Funnel Trends don't work with specific periods with granularity weeks / months

3 participants