Fix Issue with Modules Koans - #399
Merged
Merged
Conversation
- This is an expected case for Modules to be missing in the user folder so just check the path and avoid searching it if it doesn't exist yet
- Check script required modules & import them prior to invoking Pester
- Sets prevented use of -(Include)Module with -Contemplate :(
Added handling to Get-Karma to ensure Update-PSKoan copies module files when module params are specified.
- Fix edge case where PSKoans is not on PSModulePath. - Copy PSModulePath and PSKoans path into new runspace. - Propagate errors from runspace to current session in case of errors.
- Apparently Import-Module fails to recognise Unix fully qualified path
Collaborator
Author
|
Tests are required for this, but will have to wait till #398 because good lord I do not wanna go there with that merge conflict it'll cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
There seems to be a few issues with the module koans not running correctly. This PR should resolve those problems.
Context
Original issues reported by @shaneis on Discord.
Changes
Modulesfolder is missing; Get-Karma will take the correct action and cause them to be updated anyway, so the error is not useful.Checklist