Bug / Copy Fix
The user profile page uses job-application vocabulary for a section every user sees, regardless of whether they run an apply agent.
The original fix was incomplete
This ticket said "find all occurrences of the string Save Candidate Profile". There is only one — the button. Doing just that leaves a button reading "Save Profile" directly underneath a heading that still reads "Candidate Profile", which is worse than either alone.
Both user-visible strings must change together:
| File |
Line |
Current |
Change to |
store/console/src/pages/Profile.tsx |
192 |
<h3>Candidate Profile</h3> |
Profile details |
store/console/src/pages/Profile.tsx |
229 |
Save Candidate Profile |
Save Profile |
Internal identifiers (saveCandidateProfile :84, the comments at :32/:52/:189, cpFields) are not user-visible. Rename them for consistency if you like, but that is not what this ticket is for.
Leave store/console/src/tabs/SettingsTab.tsx:904 alone. It also says "Candidate profile", but it is already inside {isApply && …} — it only renders for an apply-surface agent, where the wording is correct and useful. It is the model the Profile page should follow, not a bug.
Scope boundary
The deeper problem — that this whole section is apply-specific but shown to everyone, gated on cpFields.length > 0 rather than on having an apply agent — is #222, not this ticket. Keep this one a two-string copy fix that can ship in minutes.
If #222 is picked up first, this becomes redundant: its third acceptance criterion ("no section header or button on the shared pages uses the word 'Candidate'") subsumes it. Close as superseded in that case rather than doing both.
Acceptance criteria
Related
Bug / Copy Fix
The user profile page uses job-application vocabulary for a section every user sees, regardless of whether they run an apply agent.
The original fix was incomplete
This ticket said "find all occurrences of the string
Save Candidate Profile". There is only one — the button. Doing just that leaves a button reading "Save Profile" directly underneath a heading that still reads "Candidate Profile", which is worse than either alone.Both user-visible strings must change together:
store/console/src/pages/Profile.tsx<h3>Candidate Profile</h3>Profile detailsstore/console/src/pages/Profile.tsxSave Candidate ProfileSave ProfileInternal identifiers (
saveCandidateProfile:84, the comments at:32/:52/:189,cpFields) are not user-visible. Rename them for consistency if you like, but that is not what this ticket is for.Leave
store/console/src/tabs/SettingsTab.tsx:904alone. It also says "Candidate profile", but it is already inside{isApply && …}— it only renders for an apply-surface agent, where the wording is correct and useful. It is the model the Profile page should follow, not a bug.Scope boundary
The deeper problem — that this whole section is apply-specific but shown to everyone, gated on
cpFields.length > 0rather than on having an apply agent — is #222, not this ticket. Keep this one a two-string copy fix that can ship in minutes.If #222 is picked up first, this becomes redundant: its third acceptance criterion ("no section header or button on the shared pages uses the word 'Candidate'") subsumes it. Close as superseded in that case rather than doing both.
Acceptance criteria
/profilefor any user.SettingsTab.tsx:904is unchanged (still correctly apply-gated).Related