Skip to content

Profile page: rename 'Save Candidate Profile' button to 'Save Profile' #174

Description

@serge-ivo

Bug / Copy Fix

The user profile page uses job-application vocabulary for a section every user sees, regardless of whether they run an apply agent.

The original fix was incomplete

This ticket said "find all occurrences of the string Save Candidate Profile". There is only one — the button. Doing just that leaves a button reading "Save Profile" directly underneath a heading that still reads "Candidate Profile", which is worse than either alone.

Both user-visible strings must change together:

File Line Current Change to
store/console/src/pages/Profile.tsx 192 <h3>Candidate Profile</h3> Profile details
store/console/src/pages/Profile.tsx 229 Save Candidate Profile Save Profile

Internal identifiers (saveCandidateProfile :84, the comments at :32/:52/:189, cpFields) are not user-visible. Rename them for consistency if you like, but that is not what this ticket is for.

Leave store/console/src/tabs/SettingsTab.tsx:904 alone. It also says "Candidate profile", but it is already inside {isApply && …} — it only renders for an apply-surface agent, where the wording is correct and useful. It is the model the Profile page should follow, not a bug.

Scope boundary

The deeper problem — that this whole section is apply-specific but shown to everyone, gated on cpFields.length > 0 rather than on having an apply agent — is #222, not this ticket. Keep this one a two-string copy fix that can ship in minutes.

If #222 is picked up first, this becomes redundant: its third acceptance criterion ("no section header or button on the shared pages uses the word 'Candidate'") subsumes it. Close as superseded in that case rather than doing both.

Acceptance criteria

  • No user-visible "Candidate" string remains on /profile for any user.
  • SettingsTab.tsx:904 is unchanged (still correctly apply-gated).
  • Header and button read consistently — no mixed vocabulary.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions