docs: fix scheduler policy flag, schedulerName case, and stale link - #604
Conversation
- schedulerName value is 'hami-scheduler' (lowercase, case-sensitive) - the scheduler policy is set via the --gpu-scheduler-policy flag (needs --) - point the volcano-vgpu-device-plugin link to the Project-HAMi repo Signed-off-by: wangmin <wangmin@riseunion.io>
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughDocumentation is updated to correct the ChangesDocumentation Corrections
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Wangmin362 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What this PR does / why we need it
Three small correctness fixes in scheduler/concept docs:
core-concepts/architecture.md) — the MutatingWebhook setsschedulerNametohami-scheduler(lowercase), notHAMi-scheduler. This value is case-sensitive; the same file's own section anchor is{#hami-scheduler}and the chart'sscheduler.schedulerNameishami-scheduler.developers/gpu-topology-scheduling.md) — the topology policy is set via the--gpu-scheduler-policyflag (leading--), defined inProject-HAMi/HAMicmd/scheduler/main.go(rootCmd.Flags().StringVar(&device.GPUSchedulerPolicy, "gpu-scheduler-policy", ...)). The doc dropped the--.concept.md) — thevolcano-vgpu-device-pluginlink pointed atgithub.laiyagushi.com/volcano-sh/devices; it should point togithub.laiyagushi.com/Project-HAMi/volcano-vgpu-device-plugin, which is what the other docs on this site already link to.Both the
docs/version and thei18n/zhmirror are updated.Verification
npm run check:all(markdownlint + prettier + build + linkinator) passes locally.cmd/schedulerflag definitions.AI assistance
Drafted with AI assistance (Claude Code) and reviewed and verified by me, including the source cross-checks above.
Summary by CodeRabbit