feat(collector): bridge OpAMP physical plan messages - #563
Merged
Merged
Conversation
This was referenced Sep 1, 2026
zzylol
changed the base branch from
feat/collector-plan-opamp-channel
to
main
September 2, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The MVP needs the real Collector distribution to receive compiled plans through OpAMP, apply them in process, and return exact-version status.
What
Registers
io.projectasap.collector-plan.v1, routes custom messages into the typed plan channel, applies them through Poll/Ack, publishesplan_status, rejects dual control sources, and makes shutdown/retry behavior safe.How
Bind the configured OpAMP extension to one identified Collector, validate before activation, retry when the SDK send slot is pending, and cancel transport I/O before joining the apply loop.
Before this PR
The typed channel existed only as a library boundary; the production contrib processor did not bridge OpAMP messages to runtime application.
After this PR
A targeted custom message reaches the runtime, and APPLIED is emitted only after the exact version is acknowledged.
Evidence
Execution example: bridge tests cover message routing, status publication, pending-send retry, identity validation, dual-source rejection, and shutdown deadlock regression. Visual and performance evidence are not applicable.
Verification
go test ./controlchannelandgo test -race ./controlchannel— passed../asap-otel --versionreported0.141.0-dev.Architectural decisions
Uses typed custom OpAMP messages rather than full Collector YAML; only one control source may own plan application.
Limitations and follow-up
Stacked on #562; backend counterpart is ProjectASAP/ASAPQuery-backend#452. Full verification used a temporary test-only combination of existing split DDSketch/HLL sketchlib commits, then restored the checkout; no sketchlib change is included.
Human review — do not complete with an agent