Problem
MajorPass builds Pass 1 candidates with the built-in accuracy model. PlanningModels::with_accuracy only affects the final root check. So a deployment-supplied empirical accuracy model, which #509 says is the deployment's input, cannot certify readouts during candidate generation. For example, UnivMon distinct, entropy and L2 have no calibrated built-in bound and can never be selected. Found while writing #519. Its certified_frequency_readouts_share_one_univmon_state test has to repeat MajorPass's steps by hand instead of going through e2e_plan.
Blocked on
Implementation of #511 (unified operator graph: OperatorNode with common metadata, no KeepPreAsap wrappers). Do not start before #511 is implemented.
Proposed
Thread PlanningModels.accuracy into the strategies MajorPass builds (SketchAlgorithmStrategy and the others), with no new types. Then port the UnivMon test from #519 to e2e_plan with a test accuracy model.
Related
#509 (deployment inputs), #519.
Problem
MajorPassbuilds Pass 1 candidates with the built-in accuracy model.PlanningModels::with_accuracyonly affects the final root check. So a deployment-supplied empirical accuracy model, which #509 says is the deployment's input, cannot certify readouts during candidate generation. For example, UnivMon distinct, entropy and L2 have no calibrated built-in bound and can never be selected. Found while writing #519. Itscertified_frequency_readouts_share_one_univmon_statetest has to repeat MajorPass's steps by hand instead of going throughe2e_plan.Blocked on
Implementation of #511 (unified operator graph:
OperatorNodewith common metadata, noKeepPreAsapwrappers). Do not start before #511 is implemented.Proposed
Thread
PlanningModels.accuracyinto the strategies MajorPass builds (SketchAlgorithmStrategyand the others), with no new types. Then port the UnivMon test from #519 toe2e_planwith a test accuracy model.Related
#509 (deployment inputs), #519.