refactor: name sketch and population statistic requests - #549
Merged
Merged
Conversation
zzylol
commented
Oct 2, 2026
zzylol
commented
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates two terminology changes from #536 so they can be reviewed independently of #511's operator/scalar design.
Before this PR:
SketchQuerydescribes the statistic to extract from a built sketch, andPopulationReadoutdescribes the statistic over a maintained population. The names suggest a query or execution action rather than the requested result.After this PR: these enums are named
SketchStatisticandPopulationStatistic. For example,SketchStatistic::TopK { k: 10 }andPopulationStatistic::TopK { k: 5 }still request exactly the same results. Imports, reexports, callers, tests, and current docs use the new names. The singular form describes one requested statistic per enum value.This is a Rust API naming change: variants, parameters, algorithms, and Serde representations are unchanged. It does not introduce the unified IR or rename execution methods. #536 targets this branch so these renames disappear from its incremental diff.
Validation: types and mapping tests/doctests; workspace all-target/all-feature Clippy with warnings denied; formatting and diff checks.
Stack navigation: #535 is merged; next: #536. The dependent stack has been restacked and pushed.