Conversation
Define MVP acceptance for #509 Example 1 before the Phase C stage APIs exist: 1 -> 6 -> 6 -> 1 candidates (Pass 1 x identical-expression sharing; physical operator implementation only, no materialization). - Spec with per-stage candidate tables, invariants and doc ambiguities. - Integration tests against todo!() stage stubs, ignored until the stages land; workload and Stage 0 frontend-shape tests run now. - Expected-only asap-stage-pipeline/v1 fixture for the DAG viewer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the todo!() stubs with adapters over Stage 0-3, un-ignore the 11 tests that pass, and give each still-ignored test the precise difference between the implementation and the spec. Add runtime capability checks: the selected plan compiles in the physical planner; compiling every candidate stays ignored with the two runtime gaps it finds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#509 Example 1 is the end-to-end reference for planner layering. An acceptance spec written before the implementation records what each stage must produce, and which deviations remain, so a reviewer can measure the stages against the design doc and not against themselves.
What
docs/design_docs/proposals/planner-layering-example1-acceptance.md: the MVP acceptance spec.tools/dag-viewer/examples/planner-layering-example1.expected.json: the expected-onlyasap-stage-pipeline/v1shape (data only, no viewer change).crates/integration-tests/tests/planner_layering_example1.rs: 21 tests that run against the real Stage 0–3 (10 run, 11 ignored).#[ignore]d, with the exact difference from the spec as the reason.How
The spec was written first, against
todo!()stubs (first commit). The second commit replaces the stubs with thin adapters over the stages from #575 and #576. Tests identify candidates by structure, not by id.Example 1
Before this PR: nothing checks Example 1 end to end. A stage can change its output without any test failing.
After this PR:
cargo test -p asap-integration-tests --test planner_layering_example1runs the stages and observes 1 → 24 → 24 → 1. The selected plan is P20 (Q1 exact (Sum acc, Rate acc) · Q2 exact (Sum acc)), and the test checks that it compiles in the physical planner. The ignored tests document the gaps:🤖 Generated with Claude Code