Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…de interface Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Oct 7, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design doc for discussion before code: how a summary state's coverage (source, population, time) is computed for every operator, not only the narrow
SummaryAgg→Filter/TimeRange→Scanpath in #646.Before this PR: coverage is computed only for
SummaryAgg(#646, narrow path walk) andSummaryMerge(#560). No document says what coverage any other operator's output has, although a summary's input can be any sub-DAG.After this PR: a proposal with one rule per operator, computed bottom-up, with an explicit "unknown" that only blocks merges. For each summary operator it says what
SummaryCoverage::derive(node, time_range)returns (SummaryAggderives,SummaryMergetakes the disjoint union, readouts and maintained populations carry none), and it lists the code interface:derive,merge_disjoint,validate,OperatorNode::with_time_range, and the four places that callderive. It also separates Planner coverage from ASAPQuery-backend's SDS (plan-time "which observations" vs. per-record windows and completeness).Open questions for review:
Known | Unknown,Option, or a per-source map)?time_ms, or only the time shape and leave windows to SDS?Aggregate,JoinandPromqlInfoEnrich.#646 stays the narrow first version; a follow-up PR implements this once the questions are settled.
🤖 Generated with Claude Code