Skip to content

test(control_plane): fix flaky env-var data race in unit tests #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 24, 2026
Merged

test(control_plane): fix flaky env-var data race in unit tests #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions control_plane/src/emit/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,10 @@ mod runtime_tests {

#[test]
fn emit_for_runtime_default_matches_emit_edge_yaml() {
// Serialize against the env-mutating tests in `stage_config`:
// `emit_edge_yaml` reads `ASAP_EDGE_FUSED` and must observe the
// default (unset) gate to emit the routing-connector shape.
let _env = crate::test_support::env_lock();
use crate::physical::colored_dag::emitter::{EdgeSketchProcessor, ExportTarget};
use crate::physical::colored_dag::stage_id::StageId;
use crate::sketch_algebra::params::SketchKind;
Expand Down Expand Up @@ -857,6 +861,9 @@ mod runtime_tests {
/// but the round-trip through the emitter drops the labels.
#[test]
fn workload_entry_grouping_labels_surface_in_emit_keep_keys_list() {
// Serialize against env-mutating tests: `emit_edge_yaml` reads
// `ASAP_EDGE_FUSED` and must observe the default (unset) gate.
let _env = crate::test_support::env_lock();
use crate::physical::colored_dag::emitter::{EdgeStageConfig, ExportTarget};
use crate::physical::colored_dag::stage_id::StageId;
use crate::sketch_algebra::params::SketchKind;
Expand Down
Loading