feat(control-plane): compile Planner selections into physical plans - #451
Merged
Merged
Conversation
zzylol
force-pushed
the
feat/physical-plan-compiler
branch
from
September 1, 2026 00:42
3722f7b to
d11e36c
Compare
zzylol
force-pushed
the
feat/physical-plan-compiler
branch
from
September 1, 2026 00:47
d11e36c to
229c501
Compare
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The documented MVP requires ASAPPlanner selections to become executable, target-specific physical plans instead of stopping at logical selection.
What
Adds a physical compiler that lowers Planner selections into stage allocation and backend/Collector plan materializations, with focused contract tests and implementation-aligned documentation.
How
Validate the selected primitive and runtime capabilities, allocate stages with the existing allocator/emitter pipeline, and lower the result into typed plan structures without re-planning query semantics.
Before this PR
The backend could obtain a Planner selection, but there was no production boundary that compiled it into the physical plan consumed by runtime components.
After this PR
A supported Planner selection produces a validated physical plan; unsupported or incomplete selections fail closed.
Evidence
Execution example: compiler tests cover supported compilation and rejection paths. Visual and performance evidence are not applicable.
Verification
cargo test -p control_plane physical::compiler::tests:: -- --nocapture— passed.cargo check -p control_planeandgit diff --check— passed.Architectural decisions
The compiler is a translation boundary: Planner owns selection semantics; the existing backend allocator/emitter owns executable stage layout.
Limitations and follow-up
Stacked on #450. This PR compiles plans but does not transport them; OpAMP publication is #452.
Human review — do not complete with an agent