Migrate backend to renamed ASAPPlanner APIs - #760
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ASAPPlanner #445/#447 replaced candidate-selection names and made
payload.kindthe sole executable-node operator identity. The backend pin and call sites must move together.Before this PR
For a workload such as
quantile_over_time(0.9, data[5m]), the backend usedselection.groups()andmaterialize(root)against an older Planner revision. Installed post-ASAP nodes also stored a secondoperatorfield alongside the payload.After this PR
The backend pins merged ASAPPlanner commit
10d9384, readstarget_selections()/target_subdag_candidates(), and callsassemble_selected_dag(root). Executable nodes usepayload.kindonly. The backend-owned DAG schema advances to v2; old installed DAG records are intentionally not read. No legacy API adapter is retained.Verification
cargo check -p control_plane -p data_plane --all-targets -qcargo test -p asap_types --lib -q(108 passed)cargo test -p control_plane planner_selection --lib -q(10 passed)cargo test -p control_plane physical::compiler::windows --lib -q(4 passed)cargo fmt --all --checkandgit diff --check