Skip to content

Migrate backend to renamed ASAPPlanner APIs - #760

Merged
zzylol merged 2 commits into
mainfrom
codex/planner-api-renames-2026-09-22
Sep 22, 2026
Merged

zzylol merged 2 commits into
mainfrom
codex/planner-api-renames-2026-09-22

Conversation

@zzylol

@zzylol zzylol commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Why

ASAPPlanner #445/#447 replaced candidate-selection names and made payload.kind the sole executable-node operator identity. The backend pin and call sites must move together.

Before this PR

For a workload such as quantile_over_time(0.9, data[5m]), the backend used selection.groups() and materialize(root) against an older Planner revision. Installed post-ASAP nodes also stored a second operator field alongside the payload.

After this PR

The backend pins merged ASAPPlanner commit 10d9384, reads target_selections() / target_subdag_candidates(), and calls assemble_selected_dag(root). Executable nodes use payload.kind only. The backend-owned DAG schema advances to v2; old installed DAG records are intentionally not read. No legacy API adapter is retained.

Verification

  • cargo check -p control_plane -p data_plane --all-targets -q
  • cargo test -p asap_types --lib -q (108 passed)
  • cargo test -p control_plane planner_selection --lib -q (10 passed)
  • cargo test -p control_plane physical::compiler::windows --lib -q (4 passed)
  • cargo fmt --all --check and git diff --check

@zzylol
zzylol merged commit 4112071 into main Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant