Skip to content

feat: price lifecycle placement from installed windows and all consumers #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzylol wants to merge 2 commits into
base: feat/bounded-lag-mixed-inputs
Choose a base branch
from
Open

feat: price lifecycle placement from installed windows and all consumers #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe71f1d
refactor: share the per-state window narrowing and window choice
zzylol Sep 30, 2026
ea98dc0
feat: price lifecycle placement from installed windows and all consumers
zzylol Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 37 additions & 30 deletions control_plane/src/physical/compiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,36 +1780,7 @@ impl DeploymentPlanCompiler {
.retained_physical()?
.is_some_and(|candidate| candidate.precompute.is_some());
for (ordinal, selected) in selected.into_iter().enumerate() {
let mut branch_query = query.clone();
branch_query.query_lookback_ms = selected
.window_secs
.map(|seconds| seconds.saturating_mul(1_000))
.unwrap_or(query.query_lookback_ms);
branch_query.group_by_labels = selected
.group_by
.clone()
.unwrap_or_else(|| query.group_by_labels.clone());
branch_query
.window_realization_candidates
.retain(|candidate| {
candidate.window_secs.saturating_mul(1_000)
== branch_query.query_lookback_ms
&& if cohort_nodes.contains(&(Rc::as_ptr(&selected.node) as usize)) {
if native_cohort {
windows::is_complete_window(candidate)
&& candidate.slide_secs.saturating_mul(1000)
== u64::from(
query
.summary_lifecycle_inputs
.evaluation_interval_ms,
)
} else {
windows::is_full_cohort(candidate)
}
} else {
!candidate.cohort_only
}
});
let branch_query = state_query(query, &selected, &cohort_nodes, native_cohort);
let query = &branch_query;
let lifecycle_costs = SummaryMaintenanceLifecycleCostInputs {
build_cost: Some(Cost(query.summary_lifecycle_inputs.costs.build)),
Expand Down Expand Up @@ -3885,6 +3856,42 @@ struct PlannerPhysicalSelection {
lifecycle_cost: f64,
}

/// `query` as the consumer of `state` alone: its window, grouping, and the
/// window implementations that can install it.
fn state_query(
query: &QueryCompilationInput,
state: &SelectedMaterialization,
cohort_nodes: &BTreeSet<usize>,
native_cohort: bool,
) -> QueryCompilationInput {
let mut branch = query.clone();
branch.query_lookback_ms = state
.window_secs
.map(|seconds| seconds.saturating_mul(1_000))
.unwrap_or(query.query_lookback_ms);
branch.group_by_labels = state
.group_by
.clone()
.unwrap_or_else(|| query.group_by_labels.clone());
let lookback_ms = branch.query_lookback_ms;
let cohort = cohort_nodes.contains(&(Rc::as_ptr(&state.node) as usize));
branch.window_realization_candidates.retain(|candidate| {
candidate.window_secs.saturating_mul(1_000) == lookback_ms
&& if cohort {
if native_cohort {
windows::is_complete_window(candidate)
&& candidate.slide_secs.saturating_mul(1000)
== u64::from(query.summary_lifecycle_inputs.evaluation_interval_ms)
} else {
windows::is_full_cohort(candidate)
}
} else {
!candidate.cohort_only
}
});
branch
}

fn select_lifecycle(
query: &QueryCompilationInput,
node: &SummaryNode,
Expand Down
Loading
Loading