Skip to content

refactor(query-engine): expose PromQL execution errors - #749

Merged
milindsrivastava1997 merged 2 commits into
mainfrom
747-refactorquery-engine-expose-promql-execution-errors-through-public-methods
Oct 1, 2026
Merged

milindsrivastava1997 merged 2 commits into
mainfrom
747-refactorquery-engine-expose-promql-execution-errors-through-public-methods

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Contributor

Summary

  • make the public PromQL instant/range methods return Result<Option<_>, QueryExecutionError>
  • propagate native execution errors through regular and binary query paths, while retaining Ok(None) for capability misses and no local data
  • return native execution failures locally as HTTP 500 responses without forwarding them to Prometheus

Validation

  • cargo test --workspace
  • cargo clippy -p query_engine_rust --all-targets -- -D warnings
  • pre-commit hooks (format, check, clippy, test)

@milindsrivastava1997
milindsrivastava1997 merged commit a8f57aa into main Oct 1, 2026
8 checks passed
@milindsrivastava1997
milindsrivastava1997 deleted the 747-refactorquery-engine-expose-promql-execution-errors-through-public-methods branch October 1, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(query-engine): expose PromQL execution errors through public methods

1 participant