Conversation
…baba data files The service asserted exactly one worker node, which local mode (0 nodes) never satisfies, and validated Alibaba data against MsResource_*.csv.gz, a name the exporter never reads, so valid MSMetrics/NodeMetrics data was rejected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The exporter health poll aborted on the first failed curl because the local provider raises on non-zero exits, and the monitor keyword list kept its SSH-escaped quotes locally, so no process matched and the query client never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…esults get_all_timeseries raised KeyError when a key was absent from one repetition, e.g. a series that appears mid-run, so calculate_fidelity crashed on cluster-trace runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The exporter's --data-type accepts node or ms-resource; the config value msresource was passed through, so the container exited at startup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four independent fixes found while running cluster-trace e2e experiments with the local provider on a single machine:
cluster_data_exporterlocal mode and Alibaba data-file check. The service can now run in local (single-machine) mode. Its Alibaba data-file check now looks for the file names the exporter actually reads. Tests are intest_cluster_data_exporter_service.py.Local-provider e2e runs.
curl.Tests are in
test_remote_monitor_keywords.py.Alibaba exporter flag. The exporter expects
--data-type=ms-resource; the service passedmsresource, so the container exited at startup.get_all_timeseries(asap-commonpromql_utilities/query_results/classes.py) no longer raisesKeyErrorwhen a series is missing from some repetitions. That error was crashingcalculate_fidelity.py.These are independent of the study in #746. The follow-up e2e PR, stacked on #746, needs them to run.
Validation
asap-tools/experiments:python -m unittest discover -s testspasses, 24 tests (6 new); black and flake8 are clean.🤖 Generated with Claude Code