Repository navigation
fix(asap-tools): regenerate recommended-config results with p99 rank error - #784
Merged
Merged
Conversation
…error Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
results_summary.csvfrom #752 still had the p99 runs' relative value errors: 0.1055 for the recommended KLL k=200, 0.4582 for the default K=20. It marked the recommended configuration as failing its 0.01 target. The README reports rank error (0.0019 / 0.0153) and says the recommendation meets the target, so a consumer of the CSV would conclude the opposite of the README.After this PR
The CSV is regenerated by
summarizeon main, which computes p99 rank error against the replayed trace values:These match the README. Two other differences come from the current
summarize:predicted_error;measured_error_all_keysempty, because the all-keys ARE does not apply to a quantile.All other values are unchanged.
Validation
Ran on clnode109, which holds #752's experiment outputs:
The code was ASAPQuery main at cbabfd6. The generator's output-name collision, the other CR finding on #752, is being fixed separately.
🤖 Generated with Claude Code