Repository navigation
refactor(countl2hh)!: ASAPv1 only — drop the native shim, add a golden - #175
Open
GordonYuanyc wants to merge 2 commits into
Open
GordonYuanyc wants to merge 2 commits into
GordonYuanyc wants to merge 2 commits into
Conversation
…SAPv1 golden Removes `message_pack_format::native::countsketch_topk`, CountL2HH's `MessagePackCodec` pass-through; `serialize_to_bytes` / `deserialize_from_bytes` emit the same ASAPv1 bytes. CountL2HH has no proto message and no portable type. Bumps `asapv1_golden` to the commit adding `count_l2hh_2x4_seed7`, built from the sketch's serde form with signed cells across the msgpack integer widths, `l2` accumulators set apart from the cells, and seed index 7, and adds the golden test. Docs defer the fixture coverage to the golden README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bumps `asapv1_golden` to the commit regenerating `count_l2hh_2x4_seed7` with an int16 cell and a uint32 `l2` accumulator, so the cells and accumulators reach all ten integer families. Drops the claim that `sketchlib-go` mirrors every fixture from the spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ASAPv1-only series: one PR per sketch group, each off
main. This one removes CountL2HH's nativeMessagePackCodecshim; ASAPv1 (0x19 0x00) is its only format, and it gets its first golden.Removed
message_pack_format::native::countsketch_topk(theMessagePackCodecimpl forCountL2HH). Nothing in the repo called it. CountL2HH had no proto message and no portable type.Added
count_l2hh_2x4_seed7(pushed to sketchlib-golden-bytes; submodule bumped): a 2x4 sketch at seed index 7 with counts[[127,128,65535,-32768],[-32,-33,i32::MIN,i64::MIN]]and l2[65536, i64::MAX](the saturation value), so every msgpack integer family appears. Built through CountL2HH's named serde form (no hashing;serialize_to_bytesre-checks the spec rules). Checked in both directions; the reviewer hand-decoded it against spec §3.19.Verification (rustc 1.99)
cargo fmt --check; clippy-D warningsfor all four CI feature sets;RUSTDOCFLAGS="-D warnings" cargo doc; gen-proto drift clean;asapv1_golden,--lib -- l2hh,conformance_kit -- l2hh. Implemented and reviewed by separate agents; review findings are addressed in the second commit.🤖 Generated with Claude Code