Repository navigation
refactor!: ASAPv1 as the only serialization — remove asapmsgpack and gob - #96
Open
GordonYuanyc wants to merge 5 commits into
Open
GordonYuanyc wants to merge 5 commits into
GordonYuanyc wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop common.EncodeToBytes / DecodeFromBytes and every SerializeToBytes / Deserialize*FromBytes method built on them, along with SpaceSaving's GobEncode / GobDecode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #95 (
asapv1-only/hydra). Final PR of the sketchlib-go ASAPv1-only series: removes the last non-ASAPv1 serialization. With the stack (#85 → #86–#93 via the integration branch → #94 → #95 → this) ASAPv1 is the only format in sketchlib-go;proto/and the protobuf harness were already removed in #95.Removed
wire/asapmsgpack/(encoder, decoder, cell-delta; no importers left).common.EncodeToBytes/DecodeFromBytesand everySerializeToBytes/Deserialize*FromByteson KLL, HLL (three types), Count-Min, Count Sketch, FoldCountMinSketch, FoldCountSketch andVector2D; SpaceSaving'sGobEncode/GobDecode; the helpers only the gob decoders used.Vector1D's JSON codec (only its own test used it)..gitignorelines for the deleted cross-language harness.Docs
README gains a short "Serialization" section: ASAPv1 via
wire/asapv1and per-sketchMarshalASAPv1/UnmarshalASAPv1, the spec in asap_sketchlib, and the golden repo mounted atasapv1_golden/.Open question
These Go types now have no serialized form: FoldCountMinSketch, FoldCountSketch (gob was their only format; ASAPv1 kinds 0x1b/0x1c are reserved, not designed), SpaceSaving (its gob stored only
k), CountL2HH, ExponentialHistogram, NitroSketch, OctoSketch. Rust already implements SpaceSaving (0x18), CountL2HH (0x19) and ExponentialHistogram / EHSketchList (0x13/0x14); Go codecs for those could follow.Verification (Go 1.24.9)
go build ./...,go vet ./...,go test ./...(all passing on this run;TestKLL_Reset_SubsequentInsertsis a known flake),go mod tidy -diffclean;gofmt -llists only two files already unformatted onmain. Implemented and reviewed by separate agents; review findings are addressed in the last commit. Rebased onto #95's review fixes.🤖 Generated with Claude Code