This repository was archived by the owner on Sep 12, 2026. It is now read-only.
Fix failing CI build workflow - #37
Merged
Merged
Conversation
Co-authored-by: PromoFaux <1998970+PromoFaux@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
PromoFaux
September 2, 2026 22:01
View session
PromoFaux
marked this pull request as ready for review
September 2, 2026 22:05
PromoFaux
approved these changes
Sep 2, 2026
Owner
|
@copilot please comment out the part that uploads to nuget for the time being - I need to dig about and find my account details! (Or maybe just use github to host it.. not sure how that works) |
Co-authored-by: PromoFaux <1998970+PromoFaux@users.noreply.github.com>
Contributor
Author
Commented out the Publish step in 9a2f930 - CI will now just build and test on PRs/tags, no package pushes until you're ready. |
PromoFaux
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI builds were failing on
ubuntu-latestrunners withmono: not found, exit code 127.Root cause
The
nuget restore $SOLUTIONstep used nuget.exe (installed viaNuGet/setup-nuget), which requires Mono on Linux. GitHub-hostedubuntu-latestrunners no longer ship Mono by default.Fix
All projects (
Matterhook.NET.MatterhookClient,Matterhook.NET.MatterhookClient.Tests,ManualTests) are SDK-style withPackageReference(nopackages.config), so Mono/nuget.exe isn't required at all:NuGet/setup-nugetstep andnuget restore; replaced withdotnet restore $SOLUTIONnuget pushwithdotnet nuget pushin the Publish stepactions/checkout@v2→v4andactions/setup-dotnet@v1→v4to drop deprecated Node 20 runtime warningsNot included
Did not add a
dependabot.ymlconfig, since another agent is reportedly already working on that separately.