Skip to content

[refactor] idd-list Step 5: needs-fix × PR state matrix 應展開,不該摺疊成單行 (verify follow-up from #13) #16

Description

@kiki830621

Problem

From verification of #13 (DA-4, MEDIUM — devil's advocate):
Step 5 phase × PR state matrix 把所有 needs-fix 摺疊成「(任何) → /idd-diagnose #N」,遺漏 critical case:re-verify after push fix + CONFLICTING 場景。

Type

refactor / spec completeness

Why P3

  • needs-fix 通常觸發場景是「verify FAIL → user push fix → 應 re-verify」,re-verify 必然要對既有 PR 操作(若走 PR path)
  • 實際 user flow:needs-fix + PR=CONFLICTING → 應 prompt gh pr checkout N → resolve → /idd-diagnose #N,而非單純 /idd-diagnose #N
  • spec 自己埋了 backward gap — needs-fix 處理是 v2.50 phase-only 規則延續,沒享受 v2.51 PR awareness 改造

Recommendation

Step 5 matrix 展開 needs-fix 為 4 row(no PR / draft / ready+MERGEABLE / CONFLICTING),各對應 actionable next。

Source

surfaced during /idd-verify #13 (DA-4 finding, MEDIUM severity)
Related: #13

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions