fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text)

[kiki830621]

Problem

Source: surfaced during /idd-verify #47 (codex P3 #9).

/idd-all-chain Step 0.4 (#47) 用:

HAS_DIAGNOSIS=$(gh issue view "$ROOT_ISSUE" -R "$GITHUB_REPO" --json comments \
    | jq -r '[.comments[] | select(.body | contains("## Diagnosis"))] | length')

contains("## Diagnosis") substring match — 可能 false-positive on:

• Comment body 內 quoted history (> ## Diagnosis ...)
• 討論 diagnosis 概念但不是真 diagnosis comment
• 程式碼或 docs 範例裡寫 ## Diagnosis

Type

bug

Expected

改用 anchor regex match,只認 line-start 的 ## Diagnosis:

| jq -r '[.comments[] | select(.body | test("(?m)^## Diagnosis"))] | length'

(?m) flag 讓 ^ 對 each line。

Priority

P3 (#47 base case 仍 work,只在 corner case false-positive;#47 fix-immediate 後加進 follow-up batch)

---

Current Status

**Phase**: closed
Last updated: 2026-05-10 by idd-close (cluster #49+#53)

Key Decisions

• Complexity = Simple (Layer 1 not triggered, Layer 2/P 都不命中)
• Layer V untriggered (V1=2 V4=2)
• Single-file 1-line jq filter change → /idd-implement next

Blocking

• 等 user 跑 /idd-verify --pr 58 (cluster-PR mode 6-AI ensemble)

[kiki830621]

Diagnosis

Type

bug fix (regex precision)

Analysis

Issue body 已 explicit:current contains("## Diagnosis") substring match 在 jq filter 上會 false-positive on (1) quoted history > ## Diagnosis ...、(2) 程式碼 / docs 範例內提及、(3) 概念性討論。

Fix 也 explicit:test("(?m)^## Diagnosis") — jq 的 test() 用 PCRE-like syntax 加 (?m) flag 讓 ^ 對 each line 而非 string-start。

Impact

• 改動範圍:1 個 jq filter,在 plugins/issue-driven-dev/skills/idd-all-chain/SKILL.md Step 0.4 (Diagnosis-readiness check)
• 影響使用者流程:false-positive 場景的 chain run 不會被誤判 ready;legitimate diagnosis comment 仍正確識別
• Backward compat:已有 diagnosis 的 issue 仍 pass(^## Diagnosis line-start 對 canonical diagnosis 一定 match),改動是 narrowing not broadening

Strategy

• idd-all-chain/SKILL.md Step 0.4 detection bash:contains("## Diagnosis") → test("(?m)^## Diagnosis")
• 同步 references/chain-flow.md (若有 reference 此 detection mechanism 的 prose,確認 anchor 描述一致)
• (out of scope) Same false-positive risk 在 idd-update 的 phase detection scan、idd-list Phase parsing — 留 follow-up if exhibit

Complexity

Simple (Layer 1 not triggered + Layer 2 / Layer P 都不命中)

理由:

• 單 file fix,1 行 jq filter 改動
• Behavior contract 不變(正確語意保持「detect canonical diagnosis comment」),只是 implementation 從 substring 改 anchored-line match
• 沒對外暴露新 API surface(internal detection logic refinement)
• Layer P 不命中:1 個檔案、1 個改動、no decision-heavy(jq test() 是標準解法)

Layer V 預計 untriggered(V1=2 explicit fix specified;V4=2 single-file change)— 見 audit trail。

Risks

• jq test() regex syntax compat:macOS 預設 jq vs Linux jq 的 PCRE 支援可能有差異。Mitigation:Verify (1) (?m) flag 在當前 jq 版本支援(jq --version ≥ 1.6),(2) test 既有 diagnosis comment 仍 match
• False-negative:若 future diagnosis 用非 line-start 的 ## Diagnosis(不太可能,because canonical convention is heading at line-start),會被誤判 not ready。Mitigation:canonical convention is line-start,break case 等於本 issue 的 false-negative trade-off,可接受

Vagueness Pre-check

• V1: 2 — fix explicit (single regex change with example)
• V4: 2 — Acceptance implicit but clear (false-positive corner cases stop firing)
• Triggered: no

Recommended Path

Simple → /idd-implement #53(1-line jq edit + commit + verify)。

不需 /idd-plan — scope narrow + no decision points + follow existing pattern。

[kiki830621]

Implementation Plan (cluster-PR mode #49 + #53)

兩個 #47 follow-ups 共用 1 cluster PR idd/cluster-chain-followups,各自 commit 用 Refs #N 紀律。

Files & Changes

• plugins/issue-driven-dev/skills/idd-all-chain/SKILL.md (fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53) — Step 0.4 detection bash:contains("## Diagnosis") → test("(?m)^## Diagnosis") for line-anchor regex match
• plugins/issue-driven-dev/references/usecase-routing.md (docs: clarify #37 close reason — supersession by #44 chain-solve? (sister from #48 diagnosis) #49) — 加 row 25 (after current [Bundle test] Step 2: add API #24 mention) 連到 chain-solve vs bulk-solve semantic + feature: /idd-all (無參數) bulk-solve mode — AI 自動 sequence + bundle 所有 open issue #37 parked status note + brief note in Decision tree section

Strategy

• fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53 jq filter change (1-line edit)
• docs: clarify #37 close reason — supersession by #44 chain-solve? (sister from #48 diagnosis) #49 usecase-routing.md row 添加 + Decision tree note (~10 lines edit)

Sequencing

兩個 bullet 互相 independent (touch 不同 files)。Sequential commit:

1. Commit 1: fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53 fix (smaller surface, faster verify)
2. Commit 2: docs: clarify #37 close reason — supersession by #44 chain-solve? (sister from #48 diagnosis) #49 docs (cross-link)

Each commit Refs #N (single-issue ref per commit per cluster-PR convention)。

Test Plan

(Markdown skill changes — no automated test framework。Manual smoke checks:)

• fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53: jq test 一個 example body containing canonical ^## Diagnosis (must match) vs > ## Diagnosis quoted (must NOT match)
• docs: clarify #37 close reason — supersession by #44 chain-solve? (sister from #48 diagnosis) #49: doc renders properly + cross-link pointers correct

Out-of-scope

• ✗ Same false-positive risk in idd-update / idd-list phase detection — separate follow-up if exhibit
• ✗ PATCH closed feature: /idd-all (無參數) bulk-solve mode — AI 自動 sequence + bundle 所有 open issue #37 issue body adding update note — left to user judgment

[kiki830621]

Implementation Complete

Checklist (synced from TaskList)

• plugins/issue-driven-dev/skills/idd-all-chain/SKILL.md — Step 0.4 jq filter:contains("## Diagnosis") → test("(?m)^## Diagnosis") for anchored regex match → commit ef4686a

Legend: - [x] done · - [~] skipped · - [-] won't fix
idd-close will refuse close if any - [ ] remains.

Changes

• ef4686a fix(idd-all-chain): jq filter use anchored regex to avoid false-positive on quoted '## Diagnosis' (Refs fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53)

Smoke Tests (manual — 4/4 PASS)

#	Input	Expected	Result
1	## Diagnosis\n... (canonical line-start)	true	✓ true
2	> ## Diagnosis\n... (quoted history)	false	✓ false
3	discussing ## Diagnosis concept here (mid-text)	false	✓ false
4	## Diagnosis\n\n### Type\nfeature\n (real comment-like)	true	✓ true

Files Changed

plugins/issue-driven-dev/skills/idd-all-chain/SKILL.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Sister Bugs Filed (mid-impl, v2.44.0+ #526)

(none surfaced — 1-line jq edit,no adjacent code touched。Same false-positive risk in idd-update / idd-list phase detection 屬 out-of-scope per Implementation Plan,留 separate follow-up if exhibit。)

Scope Compliance

✅ Single-file 1-line change,strictly within plan bullet。

Cluster Note

本 issue 是 cluster-PR idd/cluster-chain-followups 的 1/2 (sister: #49)。Cluster-PR mode per batch-and-cluster.md:每 issue 各自 Implementation Complete summary,不偷懶合併。

Next: verification pending

[kiki830621]

Verify (via PR #58)

Result: PASS — 0 blocking, 7 follow-up advisories (P3, see master report)
Full report: #58 (comment)

This issue's findings: see "#53 — chain-shell diagnosis-readiness false-positive" section in the linked report.

• 5/5 requirements FULLY met
• 4 P3 follow-up advisories: leading-whitespace narrowing tolerance, fenced-code false-positive, sister substring scans (idd-all/idd-list/idd-update), repo test infra gap
• Backward-compat verified: 既有 feature: /idd-all chain-solve mode — 自動接續解 spawned issues + 單 review PR #44/feature: /idd-all-chain accept multiple root issues with DFS/BFS traversal (default DFS) #46/idd-issue: 加入 multi-finding source 的 triage 機制（避免每筆 finding 手動分 create/update/comment/edit） #48 canonical diagnosis comments 不受影響

[kiki830621]

Closing Summary

Problem

/idd-all-chain Step 0.4 Phase 0 diagnosis-readiness check 用 jq '.body | contains("## Diagnosis")' 做 substring match。Substring match 在 corner cases 會 false-positive:

• Comment body 內 quoted history (> ## Diagnosis ...)
• 討論 diagnosis 概念但非真 diagnosis comment(「the canonical pattern is ## Diagnosis」)
• 程式碼或 docs 範例裡寫 ## Diagnosis

False-positive 後果:chain shell 誤判 root issue「has diagnosis」→ 跳過 AskUserQuestion → unattended /idd-diagnose 不 trigger → chain 在 vague spec 上做 design 猜測。

由 /idd-verify #47 codex P3 #9 surfaced。

Root Cause

contains() 是 substring match,不感知 markdown structure。Canonical IDD diagnosis comment 永遠是 col-0 ## Diagnosis ATX heading,但 substring 會把任何位置出現的字串都 match。

Solution

改用 jq test("(?m)^## Diagnosis") line-anchored regex:

• (?m) flag 讓 ^ 對 each line 而非 string-start
• ^## Diagnosis 強制 line-start,quoted history (> ## Diagnosis) 不 match、mid-text 不 match
• jq 用 Oniguruma 引擎,自 jq 1.5+ 支援 (?m) inline flag

改動 narrowing not broadening — backward-compat:既有 #44 / #46 / #48 canonical diagnosis comments 仍 match,empirically 驗證 old contains 與 new test() 結果完全一致。

Verification

• 4 條 manual smoke test (idd-implement Step 5):
  • ## Diagnosis\n... (canonical) → true ✓
  • > ## Diagnosis\n... (quoted) → false ✓
  • discussing ## Diagnosis concept (mid-text) → false ✓
  • ## Diagnosis\n\n### Type\nfeature\n (real comment) → true ✓
• 6-AI ensemble verify (PR cluster: chain follow-ups (#49 docs cross-link + #53 jq regex anchor) #58, master report: cluster: chain follow-ups (#49 docs cross-link + #53 jq regex anchor) #58 (comment))
  • Requirements: 5/5 FULLY met
  • Logic: PASS (15 checks 含 CRLF / indent strict / null body / multi-occurrence)
  • Security: PASS (regex hardcoded、anchored、無 backtracking; numeric guard 保留)
  • Regression: PASS (既有 issue 經 jq 1.8.1 empirical 驗證 backward-compat)
  • Devil's Advocate: 2 challenges actionable(leading whitespace narrowing / fenced-code false-positive),5 challenges break 不掉
  • Codex: PASS with 4 P3 follow-ups
• 4 P3 follow-up advisories filed (non-blocking):
  • [refactor] Sync diagnosis-detection narrowing to sister skills idd-all/idd-list/idd-update (verify follow-up from #53) #59 Phase 0.4 leading-whitespace tolerance for CommonMark indent
  • [docs] Formalize cluster-PR eligibility criteria in batch-and-cluster.md (verify follow-up from #49+#53) #60 Acknowledge fenced-code false-positive (doc or strip)
  • [test] Add shell test fixture infra for diagnosis detection logic (verify follow-up from #53) #61 Sync narrowing to sister skills idd-all/idd-list/idd-update
  • [docs] Add chain-vs-bulk note in usecase-routing.md decision tree section (verify follow-up from #49) #62 Add shell test fixture infra for diagnosis detection logic

Changes

• ef4686a fix(idd-all-chain): jq filter use anchored regex to avoid false-positive on quoted '## Diagnosis' (Refs fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53)
• Squash-merged in b696850 cluster: chain follow-ups (docs: clarify #37 close reason — supersession by #44 chain-solve? (sister from #48 diagnosis) #49 docs cross-link + fix: idd-all-chain Step 0.4 jq filter use anchored regex (avoid false-positive on quoted text) #53 jq regex anchor) (cluster: chain follow-ups (#49 docs cross-link + #53 jq regex anchor) #58)

Files Changed

• plugins/issue-driven-dev/skills/idd-all-chain/SKILL.md (+1/-1)

Cluster context

本 issue 是 cluster-PR idd/cluster-chain-followups (PR #58) 的 2/2 (sister: #49)。Per cluster-PR convention,各 issue 獨立 closing summary 不合併 — closing comment 是 IDD 紀律最神聖部分。

Closing Follow-ups Filed (v2.45.0+ #527)

(none — no orphan mentions in closing summary; the 4 P3 follow-ups (#59 / #60 / #61 / #62) referenced in Verification section were filed during /idd-verify --pr 58 Step 5b triage with explicit cross-links, not closing-comment orphans)