[refactor] idd-implement/SKILL.md has CRLF line endings — trips git diff --check

[kiki830621]

Problem

plugins/issue-driven-dev/skills/idd-implement/SKILL.md has CRLF line terminators throughout (632 CR characters; file reports "with CRLF line terminators"). The sibling skill files (idd-all, idd-verify, idd-all-chain SKILL.md, pr-flow.md) are LF.

When any line in this file is edited, git diff --check flags the touched line as trailing whitespace — the before reads as trailing whitespace. Observed on PR #94 (the #87/#74 auto-close-trap cluster): the reworded line 487 tripped git diff --check.

Type

refactor (file hygiene / line-ending normalization)

Impact

• Cosmetic CI noise — any future edit to this file trips git diff --check on the touched line.
• If CI ever runs git diff --check as a gate, edits to this file would fail it.
• Inconsistent with the other IDD skill files (LF).

Suggested fix

Convert idd-implement/SKILL.md from CRLF to LF in a dedicated commit (dos2unix or sed). Whole-file change (~632 lines) so it must be its own commit/PR — bundling into a logic change makes the logic diff unreadable. Consider a .gitattributes entry (*.md text eol=lf) to prevent recurrence.

Source

Surfaced during /idd-verify --pr 94 R1 verify (Codex reviewer non-blocking note) — the #87/#74 auto-close-trap cluster. Deliberately kept out of PR #94's scope (a 632-line line-ending diff would dwarf the 4-line logic fix).

Related: #87, #74

---

Current Status

• Phase: closed
• Diagnosed at: 2026-05-20

[kiki830621]

Diagnosis

Type

refactor (CRLF → LF line endings in idd-implement/SKILL.md)

Root Cause / Analysis

plugins/issue-driven-dev/skills/idd-implement/SKILL.md has CRLF line terminators throughout (632 CR characters; file reports "with CRLF line terminators"). Sibling skill files (idd-all, idd-verify, idd-all-chain SKILL.md, pr-flow.md) are LF. When any line in this file is edited, git diff --check flags the touched line as trailing whitespace — the \r before \n reads as trailing whitespace to git's diff checker. Causes noise in PR reviews + flags as commit issue in some pre-commit hook setups.

Impact

• plugins/issue-driven-dev/skills/idd-implement/SKILL.md — single file, full rewrite needed
• 0 behavior change — CRLF and LF are equivalent for plugin loading (Claude Code reads file content, normalizes whitespace internally)
• 0 review surface — just line ending cleanup

Strategy

• tr -d '\r' < skills/idd-implement/SKILL.md > /tmp/clean.md && mv /tmp/clean.md skills/idd-implement/SKILL.md
• Verify with file plugins/issue-driven-dev/skills/idd-implement/SKILL.md (should report no CRLF)
• Verify diff is purely CR removal, no other content change: git diff --stat
• Optional: add * text=lf eol=lf to .gitattributes for the plugin path to prevent regression

Complexity

Simple (single-file line-ending normalization with clear root cause + self-contained fix)

Layer 1 disqualifier: NO (touches behavior surface — git diff workflow)
Layer V: V1=1 (completely clear — strip CR characters), V4=1 (completely clear acceptance — file is LF, sibling files match)
Layer 2 + 3: NO (no published API change)
Layer P: NO (single mechanical fix, no decision branches)

Risks

• Single-file rewrite has potential for accidental content change — verify diff is purely ^M removal
• Sister skill files in the same repo might also have CRLF (audit + fix if found)

Residue

(none) — Pure mechanical fix. The optional .gitattributes hardening is a v2.69+ candidate if regression occurs.

Vagueness Pre-check

• V1: 2 — Strategy bullets enumerate concrete files + verification steps
• V4: 2 — Issue body's source-link + Expected (where applicable) gives explicit completion criteria
• Triggered: no — both axes ≤ 3

[kiki830621]

Closing Summary

Problem

plugins/issue-driven-dev/skills/idd-implement/SKILL.md had CRLF line terminators throughout (632 CR characters in original audit; 651 by close-time audit). Whenever any line in this file was edited, git diff --check flagged the touched line as trailing whitespace — the \r before \n reads as trailing whitespace to git's diff checker. Caused diff noise in PR reviews + potential blocking in pre-commit hook setups expecting clean files.

Root Cause

Likely artifact from a historical edit on a Windows or CRLF-default editor (or auto-line-ending-conversion from a paste). Plugin had no .gitattributes enforcing line endings, so the inconsistency persisted across subsequent edits.

Solution

Audit during fix broadened scope beyond the issue's stated single-file claim — 3 SISTER files had the same problem:

File	CR count
skills/idd-close/SKILL.md	912
skills/idd-diagnose/SKILL.md	689
skills/idd-implement/SKILL.md	651 (original scope)
skills/idd-issue/SKILL.md	2007
Total	4259 CR stripped

Fix: tr -d '\r' < file > /tmp/clean && mv /tmp/clean file for each affected file. Diff is purely whitespace (4259+ / 4259- balanced). git diff --check confirms no other whitespace issues remaining.

Verification

• Pre-fix: file plugins/issue-driven-dev/skills/idd-*/SKILL.md reported "with CRLF line terminators" for the 4 files
• Post-fix: file reports clean UTF-8 (no CRLF marker)
• Diff sanity: git diff --stat shows 4259+/4259- (purely line-ending swap, no content change)
• No regression: git diff --check clean (no trailing whitespace flags)

Audited sibling files for the same issue — idd-all, idd-all-chain, idd-list, idd-plan, idd-update, idd-comment, idd-edit, idd-config, idd-report, plus all references/*.md and scripts/*.sh — all already LF.

Changes

• Direct-commit to main: 9a7244e (skipped PR — pure whitespace + 4259-line diff would be review-noise-dominated; git diff --check clean is sufficient verification for line-ending normalization)
• No version bump — whitespace-only change doesn't warrant a release. Will roll into next semantic version (v2.69.0 candidate when chain 5 ships).
• 0 semantic change — Claude Code reads file content as text, normalizes whitespace internally regardless of CRLF / LF. Plugin loading behavior unchanged.

Residue

Future regression prevention — .gitattributes declaration like *.md text=lf eol=lf for the plugin directory would prevent future contributors from re-introducing CRLF. NOT shipped in this closing — .gitattributes adds policy surface (some contributors prefer CRLF locally, conversion happens at commit time); deferring this hardening as a v2.69+ candidate if regression occurs.