Wait for Tecan Infinite terminal responses - #1233
Merged
rickwierenga merged 1 commit intoSep 2, 2026
Merged
Conversation
Treat BY#T<n> as a timed busy response. Wait for ST before the next synchronous command, and use the advertised duration when it exceeds the default read timeout. Require scan-setting clear commands to confirm their result. Do not reinitialize the reader after an indeterminate timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Tecan Infinite can return
BY#T<n>while a command is still active. Treating this response as terminal allows another command to reach the reader before it returns to standby.ST, and extend the next read timeout to the advertised duration when it exceeds 30 seconds.MODE FI.TOPto return a terminal confirmation. Do not reinitialize the reader after an indeterminate clear timeout.Verification
.venv/bin/pytest -q pylabrobot/legacy/plate_reading/tecan/infinite_backend_tests.py— 50 passed, 29 subtests passed.venv/bin/pytest -q pylabrobot/legacy/plate_reading— 184 passed, 1 skipped, 29 subtests passed; the two warnings come from SparkAsyncMocktests outside this diffuvx --from ruff==0.15.4 ruff check pylabrobot/legacy/plate_reading/tecan/infinite_backend.py pylabrobot/legacy/plate_reading/tecan/infinite_backend_tests.py— passeduvx --from ruff==0.15.4 ruff format --check pylabrobot/legacy/plate_reading/tecan/infinite_backend.py pylabrobot/legacy/plate_reading/tecan/infinite_backend_tests.py— passeduvx --from mypy==1.18.2 mypy pylabrobot/legacy/plate_reading/tecan/infinite_backend.py— passedST; absorbance, fluorescence, and luminescence reads completed; the reader returned to standby after each mode