Fix typo - #2
Merged
Merged
Conversation
rickwierenga
added a commit
that referenced
this pull request
Nov 13, 2024
mackenziekormann
referenced
this pull request
in until-labs/pylabrobot
Dec 2, 2024
Layout manager, resources, liquid classes, serialization
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 17, 2026
…rds, docs) Grip height (#1): the movable-labware and plate definitions now set gripHeightFromLabwareBottom from the caller's pickup_distance_from_top (size_z - distance), the way STAR and Vantage do. Without it the robot-server grips at the labware z-midpoint and silently drops the requested grip line. Collision (#3): a resource that is both pipetted/well-referenced and gripper-moved was defined twice under one labware id (a wells-less stub for the gripper, the rich definition for pipetting), which the robot-server rejects as a duplicate loadLabware. The gripper now reuses any existing load and loads plates and tip racks with their real definition, so nothing is defined twice. This is broader than the plate case the review named: tip racks had the same clash. Nozzle layout (#6): configure_nozzle_layout now rejects a missing primary_nozzle (SINGLE/ROW/COLUMN/QUADRANT) and missing corner nozzles (QUADRANT) locally, instead of letting the request 422 at the server. Version floor (#2): the robot/ command family gate was an unsourced 8.3.0; lower it to the documented 8.2.0 (confirm per-unit via GET /health). Docs (#7, #5): the temperature-module docstrings and notebook constructed the now-abstract OpentronsBackend; point them at OpentronsOT2Backend. Drop a leftover "# test" marker on traversal_height. Validated on the live Flex sim: stub and plate grip-height definitions are accepted and gripper-moved, and a plate loaded for pipetting then gripper-moved is not redefined. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 17, 2026
push_out (#1): the pushOut passthrough on dispense had no test. Cover both that push_out is forwarded as pushOut and that it is omitted when unset. Dry-run seam (#2): _run_command issued raw urllib that bypassed the swappable self._ot transport, so touch_tip, blow_out_in_place, unsafe/*, and savePosition escaped the chatterbox and raised URLError on a dry run. Route _run_command through self._ot.requestor.post (which ot_api already exposes and stop() already uses), give the chatterbox a canned command result, and drop its now-dead lh.save_position stub. _request stays only for the Flex deck-config PUT, which the requestor does not expose. This also drops _run_command's lone client-side timeout, making it consistent with every other ot_api call in the backend, none of which has one. Deferred (#3): OpentronsOT2Backend._tip_volume_supported rejects any channel volume outside {20, 300, 1000}, so it throws for p10 AND p50 pipettes (both in pipette_name2volume), not just p10 as the prior note said. Left for a separate change since the correct p10/p50 tip-compatibility sets need hardware to confirm. Chatterbox seam validated by a new test (blow_out_in_place records a requestor.post instead of raising); the Flex _run_command path re-validated on the live sim (savePosition, robot/ motion, loadLabware, moveLabware). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 18, 2026
push_out (#1): the pushOut passthrough on dispense had no test. Cover both that push_out is forwarded as pushOut and that it is omitted when unset. Dry-run seam (#2): _run_command issued raw urllib that bypassed the swappable self._ot transport, so touch_tip, blow_out_in_place, unsafe/*, and savePosition escaped the chatterbox and raised URLError on a dry run. Route _run_command through self._ot.requestor.post (which ot_api already exposes and stop() already uses), give the chatterbox a canned command result, and drop its now-dead lh.save_position stub. _request stays only for the Flex deck-config PUT, which the requestor does not expose. This also drops _run_command's lone client-side timeout, making it consistent with every other ot_api call in the backend, none of which has one. Deferred (#3): OpentronsOT2Backend._tip_volume_supported rejects any channel volume outside {20, 300, 1000}, so it throws for p10 AND p50 pipettes (both in pipette_name2volume), not just p10 as the prior note said. Left for a separate change since the correct p10/p50 tip-compatibility sets need hardware to confirm. Chatterbox seam validated by a new test (blow_out_in_place records a requestor.post instead of raising); the Flex _run_command path re-validated on the live sim (savePosition, robot/ motion, loadLabware, moveLabware). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 18, 2026
push_out (#1): the pushOut passthrough on dispense had no test. Cover both that push_out is forwarded as pushOut and that it is omitted when unset. Dry-run seam (#2): _run_command issued raw urllib that bypassed the swappable self._ot transport, so touch_tip, blow_out_in_place, unsafe/*, and savePosition escaped the chatterbox and raised URLError on a dry run. Route _run_command through self._ot.requestor.post (which ot_api already exposes and stop() already uses), give the chatterbox a canned command result, and drop its now-dead lh.save_position stub. _request stays only for the Flex deck-config PUT, which the requestor does not expose. This also drops _run_command's lone client-side timeout, making it consistent with every other ot_api call in the backend, none of which has one. Deferred (#3): OpentronsOT2Backend._tip_volume_supported rejects any channel volume outside {20, 300, 1000}, so it throws for p10 AND p50 pipettes (both in pipette_name2volume), not just p10 as the prior note said. Left for a separate change since the correct p10/p50 tip-compatibility sets need hardware to confirm. Chatterbox seam validated by a new test (blow_out_in_place records a requestor.post instead of raising); the Flex _run_command path re-validated on the live sim (savePosition, robot/ motion, loadLabware, moveLabware). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 18, 2026
push_out (#1): the pushOut passthrough on dispense had no test. Cover both that push_out is forwarded as pushOut and that it is omitted when unset. Dry-run seam (#2): _run_command issued raw urllib that bypassed the swappable self._ot transport, so touch_tip, blow_out_in_place, unsafe/*, and savePosition escaped the chatterbox and raised URLError on a dry run. Route _run_command through self._ot.requestor.post (which ot_api already exposes and stop() already uses), give the chatterbox a canned command result, and drop its now-dead lh.save_position stub. _request stays only for the Flex deck-config PUT, which the requestor does not expose. This also drops _run_command's lone client-side timeout, making it consistent with every other ot_api call in the backend, none of which has one. Deferred (#3): OpentronsOT2Backend._tip_volume_supported rejects any channel volume outside {20, 300, 1000}, so it throws for p10 AND p50 pipettes (both in pipette_name2volume), not just p10 as the prior note said. Left for a separate change since the correct p10/p50 tip-compatibility sets need hardware to confirm. Chatterbox seam validated by a new test (blow_out_in_place records a requestor.post instead of raising); the Flex _run_command path re-validated on the live sim (savePosition, robot/ motion, loadLabware, moveLabware). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 18, 2026
push_out (#1): the pushOut passthrough on dispense had no test. Cover both that push_out is forwarded as pushOut and that it is omitted when unset. Dry-run seam (#2): _run_command issued raw urllib that bypassed the swappable self._ot transport, so touch_tip, blow_out_in_place, unsafe/*, and savePosition escaped the chatterbox and raised URLError on a dry run. Route _run_command through self._ot.requestor.post (which ot_api already exposes and stop() already uses), give the chatterbox a canned command result, and drop its now-dead lh.save_position stub. _request stays only for the Flex deck-config PUT, which the requestor does not expose. This also drops _run_command's lone client-side timeout, making it consistent with every other ot_api call in the backend, none of which has one. Deferred (#3): OpentronsOT2Backend._tip_volume_supported rejects any channel volume outside {20, 300, 1000}, so it throws for p10 AND p50 pipettes (both in pipette_name2volume), not just p10 as the prior note said. Left for a separate change since the correct p10/p50 tip-compatibility sets need hardware to confirm. Chatterbox seam validated by a new test (blow_out_in_place records a requestor.post instead of raising); the Flex _run_command path re-validated on the live sim (savePosition, robot/ motion, loadLabware, moveLabware). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
miikee
referenced
this pull request
in Cheshire-Labs/pylabrobot
Jul 19, 2026
push_out (#1): the pushOut passthrough on dispense had no test. Cover both that push_out is forwarded as pushOut and that it is omitted when unset. Dry-run seam (#2): _run_command issued raw urllib that bypassed the swappable self._ot transport, so touch_tip, blow_out_in_place, unsafe/*, and savePosition escaped the chatterbox and raised URLError on a dry run. Route _run_command through self._ot.requestor.post (which ot_api already exposes and stop() already uses), give the chatterbox a canned command result, and drop its now-dead lh.save_position stub. _request stays only for the Flex deck-config PUT, which the requestor does not expose. This also drops _run_command's lone client-side timeout, making it consistent with every other ot_api call in the backend, none of which has one. Deferred (#3): OpentronsOT2Backend._tip_volume_supported rejects any channel volume outside {20, 300, 1000}, so it throws for p10 AND p50 pipettes (both in pipette_name2volume), not just p10 as the prior note said. Left for a separate change since the correct p10/p50 tip-compatibility sets need hardware to confirm. Chatterbox seam validated by a new test (blow_out_in_place records a requestor.post instead of raising); the Flex _run_command path re-validated on the live sim (savePosition, robot/ motion, loadLabware, moveLabware). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rickwierenga
added a commit
that referenced
this pull request
Aug 4, 2026
Reconcile the sample-store multi-tray work with upstream's split of AutomatedRetrieval into a base + RandomAccessRetrieval / StackerRetrieval. Fold in finding #2 correctly: multi-tray support now lives in the shared AutomatedRetrieval base (loading_trays + tray_index resolution), so both RandomAccessRetrieval and StackerRetrieval are multi-tray. tray_index=None resolves to the backend's default_tray_index on BOTH the capability's resource bookkeeping and the backend's motion, so they always target the same physical tray (previously the capability hardcoded tray 0, defeating a non-zero default). - capability base owns loading_tray(s) + _loading_tray/_plate_on_loading_tray - AutomatedRetrievalBackend/StackerBackend gain default_tray_index (default 0) - Random-access + stacker ops thread tray_index through to the backend - sample store overrides default_tray_index = loading_tray_nest - 1 - Liconic/Cytomat compose RandomAccessRetrieval (single loading_tray) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.