Delay formatting type errors to improve performance of failed extractions.#315
Merged
Conversation
adamreichold
commented
Apr 6, 2022
| pub struct TypeError { | ||
| from: String, | ||
| to: String, | ||
| pub struct TypeError<'a> { |
Member
Author
There was a problem hiding this comment.
Sadly, this addition of a lifetime parameter to TypeError means this cannot be part of a maintenance release because TypeError is part of the crate API even it is not part of any type signature as it is only ever produced wrapped within PyErr. :-(
Member
Author
There was a problem hiding this comment.
Decided to actually remove DimensionalityError and TypeError from the API. They are never used directly and cannot be recovered via downcasting either. So the additional API surface does not gain us anything.
…as they are never used directly.
davidhewitt
approved these changes
Apr 9, 2022
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Nice speedup! I hadn't looked too hard at optimizing error pathways in PyO3 so far. It looks like we might be introducing some nice speedups into the 0.17 release cycle :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be especially useful for functions that accept several element types like what was discussed in #289. Even more so, as
rust-numpyimplementsPyTypeInfo::is_type_ofin terms ofFromPyObject::extract.The benchmark results seem to justify the manual implementation of
PyErrArguments: