Clean up some methods in dual module#629
Merged
Merged
Conversation
Collaborator
|
@bobbyxng pinging you on this :) |
Contributor
|
Just got back from holidays, sorry for the late feedback! @FabianHofmann @brynpickering |
FabianHofmann
added a commit
that referenced
this pull request
Jun 9, 2026
* Added m.copy() method. * Added testing suite for m.copy(). * Fix solver_dir type annotation. * Bug fix: xarray copyies need to be . * Intial commit: Working dualizer for LPs. * Fixed typing issues. Initialise dual objective with LinearExpression(None) instead of 0. * Fixed more typing issues. * Added code-block to dualize() examples. * Fix more typing issues. * Fixed variable bounds for dualisation of max problems (primal) --> reverse sign. * Updated docstrings for max -> min. * Moved copy to io.py, added deep-copy to all xarray operations. * Improved copy method: Strengtheninc copy protocol compatibility, check for deep copy independence. * Added release notes. * Made Model.copy defaulting to deep copy more explicit. * Fine-tuned docs and added to read the docs api.rst. * Clean up some methods in `dual` module (#629) * Clean up some methods in `dual` module * Typing fix (L434). * Ignore type assessment in expressions.py --------- Co-authored-by: Bobby Xiong <bobbyxng@gmail.com> Co-authored-by: Lukas Trippe <lkstrp@pm.me> * fix: use dimension coords only when adding dual variables to avoid scalar coord conflicts. * fix CI testing issues * refactor dualisation, update tests, modularise functions and vectorise code * rename to _lift_bounds_to_constraints and make private * refactor, improve docstrings * improve readability, docstring formats, testing suite * fix typing in pytests * fix typing in pytests * improve test coverage and remove non-supported objective constant * Fix cases where constraints and variables of the same block/name can have different signs and/or bounds. Add tests * revert test-models.yml environments to upstream, see PR 522 * add release notes and improve docstrings of m.dualize() * docstring improvements * Rename dual.py to dualization.py; fix array coords, strip comments, dedupe lookups Use con.indexes[dim] (pd.Index) for dual variable coords so dualizing dimensioned models no longer raises TypeError. Collapse the duplicated bounded-gather and bound-lifting blocks into shared helpers. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Annotate _gather_with_default result to satisfy mypy --------- Co-authored-by: Bryn Pickering <17178478+brynpickering@users.noreply.github.com> Co-authored-by: Lukas Trippe <lkstrp@pm.me> Co-authored-by: Fabian Hofmann <fab.hof@gmx.de> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions to:
Checklist
doc.doc/release_notes.rstof the upcoming release is included.