fix(monitoring): monitoring rendering of low traffic app - #2938
fix(monitoring): monitoring rendering of low traffic app#2938lmillie-qovery wants to merge 5 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 15f1bdc
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2938 +/- ##
===========================================
- Coverage 50.16% 50.04% -0.13%
===========================================
Files 864 1238 +374
Lines 21614 26797 +5183
Branches 6580 8010 +1430
===========================================
+ Hits 10843 13410 +2567
- Misses 8904 11145 +2241
- Partials 1867 2242 +375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: Laura Millie <lmillie@qovery.com>
945b817 to
6f2cad4
Compare
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Summary
Fixes the network monitoring charts (status/size/duration, both public envoy/nginx and private beyla
variants) rendering as broken or incomplete during low/zero-traffic periods.
network-request-size-chart.tsx, and their private-* counterparts. The filter was dropping the entire
series at a zero rate instead of letting it render as a real 0, which made an idle service look
identical to a metrics-pipeline outage.
LocalChart, so callers can now distinguish a genuinely failed query (new "Unable to load metrics"
state, driven by React Query's isError) from a successfully-empty one. All 6 network charts now pass
emptyLabel="No traffic in this period" for the latter.
addTimeRangePadding in all 6 network charts, so gaps between data points fill with 0 instead of
null. Previously a gap rendered as a visual break regardless of cause, while a timestamp where
Thanos happened to return a sample rendered as a point — producing an inconsistent, flickering line
even during genuinely idle stretches.
Test plan
tests respectively), including new get-series-keys.spec.ts
continuous line, flat at 0 during idle, real values during traffic; a simulated query failure shows
the new "Unable to load metrics" state)
Screenshot:
Before:
After:
Summary by cubic
Fixes the network monitoring charts (status/size/duration, public envoy/nginx and private beyla variants) rendering as broken or incomplete during low- or zero-traffic periods.
> 0PromQL filter so idle services render a flat 0 line instead of looking like a metrics-pipeline outage.hasError/emptyLabeltoChart.Containerso a failed query shows "Unable to load metrics" and an empty query shows "No traffic in this period".Written for commit 15f1bdc. Summary will update on new commits.