Skip to content

fix(agent-task): require a creation trigger - #2941

Merged
RemiBonnet merged 3 commits into
stagingfrom
fix/agent-task-required-automation
Sep 4, 2026
Merged

fix(agent-task): require a creation trigger#2941
RemiBonnet merged 3 commits into
stagingfrom
fix/agent-task-required-automation

Conversation

@RemiBonnet

@RemiBonnet RemiBonnet commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

Make automation mandatory in the Agent Task creation flow. Remove the "Enable agent task" toggle, require at least one Webhook or Schedule trigger before creation, and always create the Agent Task enabled once a trigger is configured.

Screenshots / Recordings

Not applicable.

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Requires at least one webhook or schedule trigger before an agent task can be created, and always creates the task enabled.

  • Removes the "Enable agent task" toggle and the workflowEnabled/webhookEnabled form fields.
  • Blocks creation without a trigger by opening the automation sheet so one can be added.
  • Sends enabled: true in the create request.

Written for commit 4e100f2. Summary will update on new commits.

Review in cubic

@nx-cloud

nx-cloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit dd352c3

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 58s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded <1s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 19s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-04 14:46:34 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.02%. Comparing base (2f6e42d) to head (4e100f2).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2941      +/-   ##
===========================================
+ Coverage    46.02%   48.02%   +1.99%     
===========================================
  Files          514      511       -3     
  Lines        13539    13353     -186     
  Branches      4178     4114      -64     
===========================================
+ Hits          6232     6413     +181     
+ Misses        6242     5841     -401     
- Partials      1065     1099      +34     
Flag Coverage Δ
unittests 48.02% <100.00%> (+1.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet
RemiBonnet merged commit df2db23 into staging Sep 4, 2026
9 checks passed
@RemiBonnet
RemiBonnet deleted the fix/agent-task-required-automation branch September 4, 2026 15:16
@RemiBonnet

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.349.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants