chore(QOV-2223): demo bump k3s to 1.36.4 - #704
Merged
Merged
Conversation
pggb25
approved these changes
Sep 1, 2026
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 1/5
cmd/demo_scripts/create_qovery_demo.shis likely unusable because the missing trailing backslash terminates thek3d cluster createcommand and breaks the surroundingif/then/elsestructure; restore the continuation and validate the script syntax before merging.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cmd/demo_scripts/create_qovery_demo.sh">
<violation number="1" location="cmd/demo_scripts/create_qovery_demo.sh:73">
P0: The added line breaks the `k3d cluster create` command and the surrounding `if/then/else`. The preceding `--port "443:443@loadbalancer"` line has no trailing backslash, so the k3d command terminates there; the new `--image '...v1.36.4-k3s1' \` then starts a separate command named `--image` whose trailing backslash swallows the `else` on the next line as an argument. With `set -eu`, `--image: command not found` (exit 127) aborts the whole demo script right after the cluster is created. Additionally, this leaves a second `--image` flag alongside the existing `--image 'docker.io/rancher/k3s:v1.33.5-k3s1'`, so the bump relies on k3d's last-flag-wins behavior rather than actually changing the pinned version. Bump the existing `--image` line to `v1.36.4-k3s1` and delete this added line.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Bumps the demo k3s cluster from 1.33.5 to 1.36.4 by passing the
docker.io/rancher/k3s:v1.36.4-k3s1image to the k3d cluster creation command. Newly created demo clusters will now run the newer k3s version.Written for commit b394f31. Summary will update on new commits.