Skip to content

chore(QOV-2223): demo bump k3s to 1.36.4 - #704

Merged
benjaminch merged 2 commits into
mainfrom
chore/demo/use-k3s-1-36-4
Sep 1, 2026
Merged

chore(QOV-2223): demo bump k3s to 1.36.4#704
benjaminch merged 2 commits into
mainfrom
chore/demo/use-k3s-1-36-4

Conversation

@benjaminch

@benjaminch benjaminch commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Summary by cubic

Bumps the demo k3s cluster from 1.33.5 to 1.36.4 by passing the docker.io/rancher/k3s:v1.36.4-k3s1 image to the k3d cluster creation command. Newly created demo clusters will now run the newer k3s version.

Written for commit b394f31. Summary will update on new commits.

Review in cubic

@benjaminch benjaminch added the enhancement New feature or request label Sep 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 1/5

  • cmd/demo_scripts/create_qovery_demo.sh is likely unusable because the missing trailing backslash terminates the k3d cluster create command and breaks the surrounding if/then/else structure; restore the continuation and validate the script syntax before merging.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cmd/demo_scripts/create_qovery_demo.sh">

<violation number="1" location="cmd/demo_scripts/create_qovery_demo.sh:73">
P0: The added line breaks the `k3d cluster create` command and the surrounding `if/then/else`. The preceding `--port "443:443@loadbalancer"` line has no trailing backslash, so the k3d command terminates there; the new `--image '...v1.36.4-k3s1' \` then starts a separate command named `--image` whose trailing backslash swallows the `else` on the next line as an argument. With `set -eu`, `--image: command not found` (exit 127) aborts the whole demo script right after the cluster is created. Additionally, this leaves a second `--image` flag alongside the existing `--image 'docker.io/rancher/k3s:v1.33.5-k3s1'`, so the bump relies on k3d's last-flag-wins behavior rather than actually changing the pinned version. Bump the existing `--image` line to `v1.36.4-k3s1` and delete this added line.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cmd/demo_scripts/create_qovery_demo.sh Outdated
@benjaminch
benjaminch merged commit a5882e6 into main Sep 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants