Skip to content

Update wording for mainnet - #51

Merged
dewabisma merged 4 commits into
mainfrom
beast/chore-remove-testnet-word
Sep 9, 2026
Merged

Update wording for mainnet#51
dewabisma merged 4 commits into
mainfrom
beast/chore-remove-testnet-word

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

Summary

  • Update mainnet wording
  • Fix selection on hero banner

@dewabisma
dewabisma requested a review from n13 September 9, 2026 11:23

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: REQUEST_CHANGES

Blocking finding:

  • website/src/i18n/en-US.json:128, and the equivalent home.loader.lines.syncing entry in every other locale, still identifies Planck as a testnet. website/src/components/features/home/TerminalLoader.astro:85-87 invokes the loader on every visitor first homepage load, and website/src/scripts/home/loader.ts:13,26-31 renders this line after 840 ms. The mainnet wording update therefore still tells each new visitor that the site is syncing Planck testnet before showing the revised hero. Please update all nine locale entries to mainnet or network-neutral wording alongside removing the footer testnet label.

Validation:

  • Reviewed the complete diff from 2851e6a to exact head 9aba9b4.
  • git diff --check passed.
  • Prettier passed for all ten changed files. The repository-wide format check still reports 26 unchanged files.
  • bun test passed: 22 tests, 0 failures.
  • Production Astro build completed successfully.
  • Locale key/type parity passed for all nine locales: 873 nodes each.

No other blocking findings.

@dewabisma
dewabisma requested a review from n13 September 9, 2026 11:58

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: APPROVE

The previous blocking issue is resolved at 5a8782f8: all nine home.loader.lines.syncing entries now identify mainnet, so first-time homepage visitors no longer see the stale Planck testnet message. I reviewed the remaining hero selection and localized wording changes and found no blocking issues.

Validation:

  • Reviewed the complete diff from base 2851e6aa to exact head 5a8782f8.
  • git diff --check passed.
  • Prettier passed for all ten changed files.
  • bun test passed: 22 tests, 0 failures.
  • The production Astro build generated all static routes, optimized assets, and the sitemap.
  • Locale key/type parity passed for all nine locales: 872 nodes each.
  • The repository-wide format and SEO checks continue to report only unrelated existing issues outside the PR hunks (26 formatting files and 17 launch-metadata length checks).

No blocking findings remain.

@dewabisma
dewabisma merged commit be5fe9d into main Sep 9, 2026
@dewabisma
dewabisma deleted the beast/chore-remove-testnet-word branch September 9, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants