Fix Resolution Search Payload 500, Grok Vision Fallbacks, and Mobile Layout Rounded Edges#739
Conversation
…ded edges Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
There was a problem hiding this comment.
Blocking findings
-
app/actions.tsx:225-227— image bytes are still persisted. The newsanitizedHistoryreplaces image parts only in the preceding history, but theresolution_search_resultmessage still storesdataUrl,mapboxDataUrl, andgoogleDataUrl(rawdata:*;base64,...strings).onSetAIStatelater serializes every message throughsaveChat, so this path still writes the screenshot payload to the database and can reproduce the reported POST /index 500. Keep the image bytes transient or persist object-storage references/metadata instead. -
lib/utils/index.ts:44and:90— unsupported vision model identifier breaks the intended fallback. WithrequireVisiontrue, bothresolutionSearchandresearcherselectgrok-vision-beta. The official xAI endpoint catalog listsgrok-2-vision-1212as the vision language model, with aliasesgrok-2-visionandgrok-2-vision-latest, notgrok-vision-beta. The selected-model branch rethrows initialization errors, while the default branch only wraps provider construction, so an image request cannot reliably fall back to another provider. Use a supported vision ID and handle fallback around the actual request.
Existing head checks were inspected but not rerun: GitGuardian passed; Supabase Preview was skipped; the Vercel preview check is green while the Vercel – qcx commit status is currently failing; the CLA status is pending.
…ve build error Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
19efd12
into
jules-16371461960223442218-00c8db21
This submission fixes the POST /index 500 error by sanitizing history payloads to remove raw base64 image strings before saving to the database, maps vision models correctly, improves timezone safety, and rounds visual edges and elements in the mobile layout. It also restores and unclips the missing Plus icon on mobile and styles empty screen cards elegantly.
PR created automatically by Jules for task 254326844332553661 started by @ngoiyaeric