fix(deps): bump rustls to 0.23.45 for RUSTSEC-2026-0285 - #27
Open
QuicksilverSlick wants to merge 2 commits into
Open
QuicksilverSlick wants to merge 2 commits into
QuicksilverSlick wants to merge 2 commits into
Conversation
cargo-deny fails the Security job on every main commit: rustls 0.23.42 accepts TLS 1.3 handshake messages across encryption-level boundaries (GHSA-2mjx-qc3c-rqvc). Patched in 0.23.45. `cargo update -p rustls --precise 0.23.45` in the root workspace and in desktop/src-tauri. It also moves aws-lc-rs to 1.18.1, aws-lc-sys to 0.45.0 and rustls-webpki to 0.103.15, the same versions upstream block/buzz locks (it bumped them incidentally in block#7646, an iOS build fix not worth cherry-picking whole). No packages added or removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Local
The desktop workspace no longer reports RUSTSEC-2026-0285 either. CI doesn't run cargo-deny on |
A Cargo.lock change misses the exact-key relay-artifacts cache, and PR runs only read sccache, so the relay build plus both nextest archives recompile from source. On this branch that took more than 30 minutes and the job was cancelled while still archiving backend tests. Upstream block/buzz made the same change in block#7620 (4d08194). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Security Domain / Security has failed on every main commit (49850a9, 36e4d19, 6bf3f0f). The job runs
cargo-deny checkagainst the rootCargo.lock, and cargo-deny reports RUSTSEC-2026-0285 (GHSA-2mjx-qc3c-rqvc). The advisory says rustls 0.23.42 accepts TLS 1.3 handshake messages across encryption-level boundaries. The fix is in rustls >= 0.23.45.The failure started with the new advisory, not with a code change. No recent merge touched a dependency file.
What
cargo update -p rustls --precise 0.23.45, run in both workspaces:Cargo.lockdesktop/src-tauri/Cargo.lockUpstream block/buzz now locks these same versions. It got them as a side effect of block#7646 (7c789de), an iOS simulator build fix that also changes the Podfile, pubspec and a CI job, so I didn't cherry-pick that commit.
Neither lockfile gains or loses a package (1043 and 1231 before and after). Cargo also re-pointed a few range dependencies at versions already in the lock (
data-encoding-macro-internal→ syn 1.0.109, which upstream's lock also has; some desktopwindows-sysedges 0.52 → 0.59).CI: Desktop E2E Relay timeout 30 → 45 min
This PR's first CI run cancelled Relay Artifact Producer / Desktop E2E Relay at its 30-minute limit, and it wasn't a test failure. The relay-artifacts cache only hits on an exact key that includes
Cargo.lock, and PR runs only read sccache. So after this bump the relay build (7m21s) and bothnextest archivesteps compile from source, and the job ran out of time while still archiving backend tests. The first push build on main after merge has the same cold start. Upstream block/buzz raised this timeout from 30 to 45 minutes in block#7620 (4d08194), a day after its own rustls bump; the second commit makes the same one-line change.Checks
cargo metadata --lockedpasses in both workspaces.cargo-deny checkresult: see the comment below.🤖 Generated with Claude Code