[GRDM-58288] Replace chardet with charset-normalizer - #24
Closed
chiku-samugari wants to merge 1 commit into
Closed
chiku-samugari wants to merge 1 commit into
chiku-samugari wants to merge 1 commit into
Conversation
`chardet` 7 introduces breaking API changes that remove the `universaldetector` module used by `open_guess_encoding` function. Switch to charset-normalizer, which is a drop-in alternative that requests supports natively. This follows the upstream fix in jupyterhub/repo2docker PR#1510.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chardetはバージョン7でAPIの破壊的変更があるので、chardetの代わりにcharset-normalizerを使うように変更するPRです。upstreamで同様の変更がPR#1510として取り入れられており、このPRはプロジェクト設定ファイルの違い (upstream:pyproject.toml、本フォーク:setup.py)以外はupstreamに取り入れられたのと同じ内容です。