fix function header GetClosestGpusToNic - #238
Merged
Merged
Conversation
fix the function header GetClosestGpusToNic to match the function definition and function calls
AtlantaPepsi
approved these changes
Mar 6, 2026
AtlantaPepsi
pushed a commit
that referenced
this pull request
Mar 19, 2026
* fix qpCount storage limit to allow 256+ (#237) * fix function header GetClosestGpusToNic (#238) fix the function header GetClosestGpusToNic to match the function definition and function calls * Fixed CQ size for high QPs cases and poll CQ in batch CQ Size: max(100, qpCount) - dynamically sized This avoid hangs at large QPs size, notably experienced with small message size (ex: 256 QPs, 8M message size) Polling: Up to 32 completions per poll call to reduce poll calls * improve DMABUF zcat check improve DMABUF zcat check, similar to ROCM-2855 * add NIC_CQ_POLL_BATCH option as CQ poll batch size Add NIC_CQ_POLL_BATCH as an option to ibv_poll_cq for CQ poll batch size set a default value to `4` which appears to be current RCCL default replace fixed wc_array with vector wc.data Files changed: - `src/header/TransferBench.hpp` - `src/client/EnvVars.hpp` * align with develop * wc_array move out of the while loop from PR review * Update CHANGELOG.md * Revert "fix function header GetClosestGpusToNic (#238)" This reverts commit a8cf384. * Revert "improve DMABUF zcat check" This reverts commit 6d88473. --------- Co-authored-by: Pak Nin Lui <pak.lui@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix the function header
GetClosestGpusToNicto match the function definition and function callsTechnical Details
The function header
GetClosestGpusToNiclooks different than in the comments for the header, it seems to be some typo with this function header, so I am trying to match the function definition and function calls elsewhere in this file.Test Plan
Tried to run
TransferBenchto see the closest GPU to NICs.Submission Checklist