Skip to content

feat(ck): add gfx90c build support (cherry-pick rocm-libraries#9333) - #3757

Merged
illsilin merged 1 commit into
ROCm:pytorch/release/2.11from
harkgill-amd:gfx90c-torch2.11
Jul 23, 2026
Merged

feat(ck): add gfx90c build support (cherry-pick rocm-libraries#9333)#3757
illsilin merged 1 commit into
ROCm:pytorch/release/2.11from
harkgill-amd:gfx90c-torch2.11

Conversation

@harkgill-amd

Copy link
Copy Markdown
Contributor

Proposed changes

Cherrypicking ROCm/rocm-libraries#9333 into pytorch/release/2.11 branch. Intention is to bump the ROCm/pytorch release/2.11 CK submodule to pick up this change and resolve below build failures,

FAILED: [code=1] caffe2/aten/src/ATen/CMakeFiles/ck_gemm.dir/native/hip/bgemm_kernels/bgemm_kernel_bf16bf16bf16_64_16x16x64_16x16_1x1_8x8x1_8x8x1_1x16x1x4_4_Intrawave_v1.hip.o
/__w/rockrel/rockrel/external-builds/pytorch/pytorch/aten/src/ATen/../../../third_party/composable_kernel/include/ck/utility/amd_buffer_addressing_builtins.hpp:49:48: error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD'
   49 |     wave_buffer_resource.config(Number<3>{}) = CK_BUFFER_RESOURCE_3RD_DWORD;
4 errors generated when compiling for gfx90c.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@illsilin
illsilin merged commit b64b852 into ROCm:pytorch/release/2.11 Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants