Skip to content

Missing Q from second quoting example - #4822

Merged
coke merged 3 commits into
Raku:mainfrom
habere-et-dispertire:patch-1
Aug 31, 2026
Merged

coke merged 3 commits into
Raku:mainfrom
habere-et-dispertire:patch-1

Conversation

@habere-et-dispertire

Copy link
Copy Markdown
Contributor

Line 28 is missing Q at the start .

I added say and semicolons so that the entire example runs -- but feel free to omit that if you think it makes it clearer .

I'm unfamiliar with the :skip-test but I imagine we can omit that then too ?

🍓

Line 28 is missing `Q` at the start .

I added `say` and semicolons so that the entire example runs -- but feel free to omit that if you think it makes it clearer .

I'm unfamiliar with the `:skip-test` but I imagine we can omit that then too ?
@coke

coke commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

The Q isn't necessary there, is it? (this example is highlighting the quotes, not the Q)

@coke

coke commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

I'm unfamiliar with the :skip-test but I imagine we can omit that then too ?

Yes, if the code compiles cleanly, remove the skip-test attribute - this will cause the tests to rerun and you can see the result in the CI

@habere-et-dispertire

Copy link
Copy Markdown
Contributor Author

Aside: I think rakupp is pulling examples from documentation marked as passing for its tests. This then happens to help with that effort as the suggestion makes it self-contained.

@raiph

raiph commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

@habere-et-dispertire

To elaborate on @coke's comment about the "Missing Q"...

As I understand it, one is supposed to be allowed to omit the Q prefix in the specific case that the opening delimiter character is 「.

Indeed, Rakudo supports that case -- one can write say 「More plainly.」 and it works in the glot.io Rakudo and has as far back as I remember, more than a decade if I recall correctly. (So while it's entirely possible no one has ever used it in code they care about, it's also possible they have.)

@coke

coke commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

@raiph - deprecating features in rakudo has nothing to do with the doc ticket and adding this here complicates our ability to resolve this documentation pull request.

@raiph

raiph commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@coke

Point taken. Sorry about that. Comment edited to remove that aspect (and indeed the notion of even mentioning it given that what it's doing is ultimately reasonable anyway). So, FWIW, from my perspective this PR is good to go.

@coke
coke merged commit 24107bd into Raku:main Aug 31, 2026
1 check passed
@habere-et-dispertire
habere-et-dispertire deleted the patch-1 branch August 31, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants