Update .github build scripts- cleanup, use Ubuntu-20.04, use Node-20#1246
Merged
TronBlack merged 1 commit intoMay 10, 2024
Merged
Conversation
HyperPeek
approved these changes
May 5, 2024
HyperPeek
left a comment
Contributor
There was a problem hiding this comment.
Similar to update on develop, straight forward change, approved.
TronBlack
approved these changes
May 10, 2024
TronBlack
left a comment
Collaborator
There was a problem hiding this comment.
+1
Reviewed. Not sure removal of dependency build is necessary (vs setting FORCEBUILDDEPS="0", but it can be fixed/replaced later if desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ravencoin repository tests each new Pull Request submission by attempting to build binaries with the new PR. But for the past year, it has interpreted all PRs as bad because the code for the build system is broken. Specifically, it uses Ubuntu-18.04 which is no longer supported by Github (fails) and it uses Node-16 which is deprecated (generates errors).
This PR updates Ravencoin's build system to use Ubuntu-20.04 and Node-20. It also removes code related to AWS cache storage which Overstock used years ago, and it does some other code clean-up.
This PR is for the master branch. Another PR has been submitted for the develop branch.
No changes are made to the actual Ravencoin source code outside of the build system.
Similar build system changes have already been implemented and tested on the Evrmore blockchain codebase.