Skip to content

Implements MGET command#31

Merged
gkorland merged 3 commits into
RedisJSON:masterfrom
bsbodden:bsb/feat-implement-mget-command
Feb 3, 2021
Merged

Implements MGET command#31
gkorland merged 3 commits into
RedisJSON:masterfrom
bsbodden:bsb/feat-implement-mget-command

Conversation

@bsbodden

Copy link
Copy Markdown
Contributor

@gkorland
gkorland requested a review from sazzad16 February 1, 2021 10:12

@sazzad16 sazzad16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format with spaces.

@bsbodden
bsbodden force-pushed the bsb/feat-implement-mget-command branch from 47c2942 to 6aac2a0 Compare February 1, 2021 20:38
@codecov

codecov Bot commented Feb 1, 2021

Copy link
Copy Markdown

Codecov Report

Merging #31 (efe9087) into master (f2badfa) will increase coverage by 34.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   61.58%   95.83%   +34.24%     
===========================================
  Files           2        2               
  Lines         151       24      -127     
  Branches       14        0       -14     
===========================================
- Hits           93       23       -70     
+ Misses         49        1       -48     
+ Partials        9        0        -9     
Impacted Files Coverage Δ
...ain/java/com/redislabs/modules/rejson/JReJSON.java 100.00% <100.00%> (+39.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2badfa...efe9087. Read the comment docs.

@bsbodden

bsbodden commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

Format with spaces.

That's what I get for opening this with Eclipse. I took care of it.

@bsbodden
bsbodden requested a review from sazzad16 February 1, 2021 20:39
Comment thread src/main/java/com/redislabs/modules/rejson/JReJSON.java Outdated
Comment thread src/main/java/com/redislabs/modules/rejson/JReJSON.java Outdated
Comment thread src/test/java/com/redislabs/modules/rejson/ClientTest.java Outdated
Comment thread src/main/java/com/redislabs/modules/rejson/JReJSON.java Outdated
Comment thread src/test/java/com/redislabs/modules/rejson/ClientTest.java
@bsbodden
bsbodden force-pushed the bsb/feat-implement-mget-command branch 2 times, most recently from 0e0038b to 1482db0 Compare February 2, 2021 14:25

@sazzad16 sazzad16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get annoyed :P

Comment thread src/test/java/com/redislabs/modules/rejson/ClientTest.java Outdated
@bsbodden
bsbodden requested a review from sazzad16 February 2, 2021 20:42
@bsbodden
bsbodden force-pushed the bsb/feat-implement-mget-command branch from 1482db0 to 846a782 Compare February 2, 2021 20:45
@gkorland
gkorland merged commit 9b40f4f into RedisJSON:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants