feat(tests): add regression coverage for TxStatus handling in Activit… - #856
Open
BigJohn-dev wants to merge 1 commit into
Open
BigJohn-dev wants to merge 1 commit into
BigJohn-dev wants to merge 1 commit into
Conversation
|
@BigJohn-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #672
Pull Request Description
Issue
Add regression coverage for
TxStatusfailure and empty-result handling inActivityItem.Summary
TxStatusAPI andnormalizeTxStatusbehavior: missing, empty, whitespace-only, and unsupported statuses returnundefined.ActivityItemcomponent body so the receipt and focused tests can compile, retaining its existing receipt toggle, unread action, icon, and actor behavior.reorgalias, and the neutral receipt placeholder for an unsupported runtime status.Exercised Cases
reorgalias handling.undefined.—, retains thestatus-unknownclass, and does not render an on-chain badge.Validation
npx vitest run --coverage.enabled=false src/components/ActivityItem.test.tsxpassed (25 tests).npx eslint src/components/ActivityItem.tsx src/components/ActivityItem.test.tsxpassed.npm run buildpassed; Vite reports its existing large-chunk advisory.SaveAsDraft,ComplianceSeverityBadge,RedemptionBanner, andGovernanceProposalDetailtests.KycSelfieCapture,TwoFactorSetup.test.tsx,AuditTrail, andDistributionDashboard). The default focused test command with repository coverage enabled also hits the unrelatedDistributionDashboardparse error during coverage remapping.