fix: count source appends and prepends in Bundle#length - #344
Open
wahidrizka wants to merge 1 commit into
Open
Conversation
Bundle#length summed each source's MagicString#length(), which by design does not count text appended or prepended at a source's edges. Since toString() renders every source in full, length() undercounted whenever a source had such edge content. It now mirrors toString() by measuring the rendered length of each source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle#length()is meant to equalBundle#toString().length. Its existing tests assert exactly that for the default separator, a custom separator, a per-source separator, and the intro.However, it summed each source with
MagicString#length(), which by design does not count text appended or prepended at the edges of a source.toString()renders each source withsource.content.toString(), so that edge content appeared in the output but was missing from the length.The fix measures each source's rendered length (
source.content.toString().length), mirroring whattoString()already does per source. I added a test that fails on the old code and passes now; the suite goes from 262 to 263 passing, andtscandeslintare clean.