Conversation
On win32, path.join of a POSIX npm root still contains backslashes, so the exists mock compared the POSIX case against C:\npm\node_modules and the BOM/CRLF probe test failed on validate-platforms (windows-latest). Pass the expected root per case instead.
Roarpeng
marked this pull request as ready for review
September 15, 2026 13:22
Roarpeng
force-pushed
the
cursor/m87-windows-global-probe-1c71
branch
from
October 1, 2026 01:13
57f4cdb to
209951e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded
Maintainer landed the same fix on
mainas4ed08d1(fix(tests): make the BOM/banner probe test separator-agnostic). Windowsvalidate-platformsis green there (32/32).This PR is obsolete — do not merge. Same root cause as #51.
Original: the m87
existsmock usedp.includes("\\")to pick Windows vs POSIX expected paths. On win32,path.join("/usr/lib/node_modules", …)still contains backslashes, so the POSIX fixture compared againstC:\npm\node_modulesandfoundwas undefined.