Conversation
…sqlite Default auto transport opens better-sqlite3. Import/export left the handle open, so afterEach rmSync hit EBUSY on Windows validate. Close the client in finally and ignore leftover unlink errors.
Roarpeng
force-pushed
the
cursor/fix-skill-md-windows-ebusy-aad7
branch
from
October 1, 2026 01:13
161e2fe to
57dfe58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
main@4cda297(v1.24.0) failedvalidate-platforms (windows-latest):Default
graphPolicy.transportisauto(sqlite whenbetter-sqlite3is present). Skill markdown import/export opened a client and neverclose()’d it, soafterEachrmSynccould not delete the temp dir on Windows.Changes
importSkillsFromMarkdownRuntime/exportSkillsToMarkdownRuntime/extractDialogueKnowledgeRuntimeclose the graph client infinally.Validation
npx vitest run tests/skill-markdown-progressive.test.ts tests/skill-markdown-interop.test.ts— 12 passed (Linux). Windows coverage is the CI job this unblocks.