This repository was archived by the owner on May 15, 2026. It is now read-only.
Delete task confirmation enhancements - #1245
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 21fed4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrubens
approved these changes
Feb 28, 2025
8 tasks
cte
force-pushed
the
cte/delete-confirmation-enhancements
branch
2 times, most recently
from
February 28, 2025 05:35
a8a9ffb to
bb9c6da
Compare
cte
force-pushed
the
cte/delete-confirmation-enhancements
branch
from
February 28, 2025 06:26
55c30da to
21fed4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some things that were bugging me:
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Enhances task deletion confirmation with a dialog, keyboard shortcuts, and Shift+Click support in
TaskHeader.tsxandHistoryView.tsx.TaskHeader.tsxandHistoryView.tsx.DeleteTaskDialogto handle Enter key for deletion and Escape key for closing.TaskActionsinTaskHeader.tsxto include confirmation logic.HistoryView.test.tsxfor confirmation dialog and Shift+Click behavior.This description was created by
for 21fed4c. It will automatically update as commits are pushed.