Skip to content

bool is a keyword in C23#716

Merged
tridge merged 1 commit into
RsyncProject:masterfrom
mruprich:gcc-15
Aug 23, 2025
Merged

bool is a keyword in C23#716
tridge merged 1 commit into
RsyncProject:masterfrom
mruprich:gcc-15

Conversation

@mruprich

Copy link
Copy Markdown
Contributor

GCC15 has landed in Fedora Rawhide and 'bool' is a new keyword in C23 standard. I have added a condition around the typedef for bool so that with newer GCC, the build won't fail with following error:

wildtest.c:35:14: error: ‘bool’ cannot be defined via ‘typedef’
   35 | typedef char bool;
      |              ^~~~
wildtest.c:35:14: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
wildtest.c:35:1: warning: useless type name in empty declaration
   35 | typedef char bool;
      | ^~~~~~~

@mruprich

Copy link
Copy Markdown
Contributor Author

I see that all tests have passed here but I am also getting notifications from github about a failed MacOS test which I don't see listed here. The test runs roughly once per day judging from the notifications.

@eworm-de

eworm-de commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Can we merge this? I would like to just cherry-pick this into out package instead of handling patches. Thanks!

@eworm-de

eworm-de commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

BTW, this contains a merge commit now... Anybody should press the rebase button.

@tridge tridge merged commit a4b926d into RsyncProject:master Aug 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants