bool is a keyword in C23#716
Merged
Merged
Conversation
tridge
approved these changes
Jan 17, 2025
Contributor
Author
|
I see that all tests have passed here but I am also getting notifications from github about a failed MacOS test which I don't see listed here. The test runs roughly once per day judging from the notifications. |
Contributor
|
Can we merge this? I would like to just cherry-pick this into out package instead of handling patches. Thanks! |
Contributor
|
BTW, this contains a merge commit now... Anybody should press the rebase button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC15 has landed in Fedora Rawhide and 'bool' is a new keyword in C23 standard. I have added a condition around the typedef for bool so that with newer GCC, the build won't fail with following error: