fix(core): await secrets store close during TaskStore shutdown

[plarson]

Summary

• Waits for the task store's secrets database handle to close during shutdown before returning.
• Updates workflow gate expectations for the current built-in lifecycle nodes.
• Adds a patch changeset for the published CLI package.

Test Plan

• corepack pnpm install
• corepack pnpm check:changesets
• corepack pnpm lint
• corepack pnpm build
• corepack pnpm test

Summary by CodeRabbit

• Bug Fixes
  • Improved shutdown behavior so task-store cleanup now waits for secrets storage to close before finishing.
  • Reduced the chance of teardown race conditions and incomplete cleanup during app shutdown.

[ghost]

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

	Title
1	Await secrets store closure during TaskStore shutdown
2	Add changeset for TaskStore shutdown fix

_{Chapters generated by Stage for commit af99a35 on Jun 30, 2026 12:15am UTC.}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cd29fc2-6235-4842-ad45-a7097d6c6acb

📥 Commits

Reviewing files that changed from the base of the PR and between 02a33c6 and af99a35.

📒 Files selected for processing (2)

• .changeset/thin-rocks-post.md
• packages/core/src/store.ts

✅ Files skipped from review due to trivial changes (1)

• .changeset/thin-rocks-post.md

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/core/src/store.ts

---

📝 Walkthrough

Walkthrough

TaskStore.close() is updated to await the secretsCentralCore.close() call (previously fire-and-forget), capturing the instance first, nulling the field, then awaiting with a try/catch warning. A changeset entry records this as a patch fix.

Changes

TaskStore secrets core shutdown fix

Layer / File(s)	Summary
Await secrets core close packages/core/src/store.ts, .changeset/thin-rocks-post.md	TaskStore.close() now captures secretsCentralCore, clears the field, and awaits close() with a try/catch warning on failure. Changeset documents the patch release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• gsxdsm

Poem

🐇 A secret once closed in a fire-and-forget,
Now awaited with care, no loose thread to fret.
The store shuts its doors in an orderly way,
No race in the teardown to ruin the day.
Hop hop, patch applied — all tidy and set! 🌿

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: TaskStore now awaits secrets store closure during shutdown.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR makes TaskStore shutdown more deterministic by awaiting the secrets CentralCore close path and adds a patch changeset for the published CLI package.

Changes:

• Await secretsCentralCore.close() during TaskStore.close() and clear the field before awaiting to keep shutdown idempotent.
• Log (best-effort) if secrets CentralCore teardown fails instead of silently ignoring it.
• Add a patch changeset for @runfusion/fusion describing the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
packages/core/src/store.ts	Awaits secrets CentralCore shutdown during TaskStore close to reduce teardown races and improve shutdown determinism.
.changeset/thin-rocks-post.md	Adds a patch changeset for @runfusion/fusion documenting the shutdown fix.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[greptile-apps]

Greptile Summary

This PR fixes a shutdown race in TaskStore.close() where secretsCentralCore.close() was called with void (fire-and-forget), allowing the store's teardown to return before the secrets DB handle was fully released. The fix awaits the close and wraps it in a try/catch, consistent with the existing pluginStore teardown pattern.

• packages/core/src/store.ts: captures secretsCentralCore locally, nulls the field before calling close (prevents re-entrant access), then awaits CentralCore.close() — which is itself async Promise<void> — with an error-handled console.warn fallback.
• .changeset/thin-rocks-post.md: adds a patch changeset for @runfusion/fusion with the required labeled fields (summary, category, dev).

Confidence Score: 5/5

Safe to merge — the change is a targeted one-line async fix in the shutdown path with no effect on the hot path.

The fix is narrowly scoped to TaskStore.close(), a path only exercised during teardown. CentralCore.close() is already async Promise, so adding await is correct; the local-capture + null-before-close pattern prevents any re-entrant access; and the try/catch with console.warn matches every other handle teardown in the same function. No callers are broken because TaskStore.close() was already declared async.

No files require special attention.

Important Files Changed

Filename	Overview
packages/core/src/store.ts	Fixes shutdown race by awaiting secretsCentralCore.close() instead of firing and forgetting; pattern matches existing pluginStore teardown and is correctly guarded with null-before-close and try/catch.
.changeset/thin-rocks-post.md	New patch changeset; uses required labeled-field format with correct bump type, category, and dev fields.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Caller
    participant TaskStore
    participant SecretsCentralCore

    Caller->>TaskStore: close()
    TaskStore->>TaskStore: flush agent log buffer
    TaskStore->>TaskStore: close _db / _archiveDb
    TaskStore->>TaskStore: capture secretsCentralCore local ref
    TaskStore->>TaskStore: "this.secretsCentralCore = null"
    TaskStore->>SecretsCentralCore: await close()
    alt close() succeeds
        SecretsCentralCore-->>TaskStore: resolved
    else close() throws
        SecretsCentralCore-->>TaskStore: error
        TaskStore->>TaskStore: console.warn (swallow)
    end
    TaskStore->>TaskStore: "secretsStore = null"
    TaskStore->>TaskStore: pluginStore.close() (sync)
    TaskStore-->>Caller: void (teardown complete)

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Caller
    participant TaskStore
    participant SecretsCentralCore

    Caller->>TaskStore: close()
    TaskStore->>TaskStore: flush agent log buffer
    TaskStore->>TaskStore: close _db / _archiveDb
    TaskStore->>TaskStore: capture secretsCentralCore local ref
    TaskStore->>TaskStore: "this.secretsCentralCore = null"
    TaskStore->>SecretsCentralCore: await close()
    alt close() succeeds
        SecretsCentralCore-->>TaskStore: resolved
    else close() throws
        SecretsCentralCore-->>TaskStore: error
        TaskStore->>TaskStore: console.warn (swallow)
    end
    TaskStore->>TaskStore: "secretsStore = null"
    TaskStore->>TaskStore: pluginStore.close() (sync)
    TaskStore-->>Caller: void (teardown complete)

Loading

_{Reviews (5): Last reviewed commit: "test(engine): align workflow gate expect..." | Re-trigger Greptile}

[gsxdsm]

@copilot resolve the merge conflicts in this pull request