Skip to content

test(engine): fix moved skill resolver fixture import - #3328

Merged
gsxdsm merged 1 commit into
Runfusion:mainfrom
plarson:fix/ce-skill-resolver-fixture
Aug 4, 2026
Merged

test(engine): fix moved skill resolver fixture import#3328
gsxdsm merged 1 commit into
Runfusion:mainfrom
plarson:fix/ce-skill-resolver-fixture

Conversation

@plarson

@plarson plarson commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update the CE workflow-step fixture runtime import to the moved cli-runtime/skill-resolver.js path
  • align the runtime specifier with the existing type-only import

Test plan

  • pnpm --filter @fusion/engine exec vitest run --project=engine-default src/__tests__/ce-workflow-step-executor.test.ts --silent=passed-only --reporter=dot --maxWorkers=1 --no-file-parallelism (52 passed)
  • pnpm --filter @fusion/engine typecheck
  • pnpm check:changesets

Summary by CodeRabbit

  • Tests
    • Updated test configuration to reference the correct skill resolver location.

Copilot AI lite review requested due to automatic review settings August 4, 2026 07:56
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 214aaf78-0f3d-4dc5-911a-998fb8612860

📥 Commits

Reviewing files that changed from the base of the PR and between eddca9b and 61df9a8.

📒 Files selected for processing (1)
  • packages/engine/src/__tests__/ce-workflow-step-executor.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/engine/src/tests/ce-workflow-step-executor.test.ts

📝 Walkthrough

Walkthrough

The workflow step executor test updates its skill-resolver import to use the relocated cli-runtime/skill-resolver.js module.

Changes

Skill resolver import relocation

Layer / File(s) Summary
Update workflow executor test import
packages/engine/src/__tests__/ce-workflow-step-executor.test.ts
The test imports createSkillsOverrideFromSelection and resolveSessionSkills from the relocated CLI runtime module.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the fixture import path fix caused by the moved skill resolver.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CE workflow-step executor test fixture to load the skill resolver from its new cli-runtime/skill-resolver.js path, keeping the runtime import specifier consistent with existing type-only imports in the engine codebase.

Changes:

  • Update the vi.importActual(...) runtime specifier from ../skill-resolver.js to ../cli-runtime/skill-resolver.js in the CE workflow-step executor test.
  • Align the runtime import path with the type import path used elsewhere (../cli-runtime/skill-resolver.js).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@plarson
plarson force-pushed the fix/ce-skill-resolver-fixture branch 2 times, most recently from 9017dd8 to eddca9b Compare August 4, 2026 08:52
@plarson
plarson force-pushed the fix/ce-skill-resolver-fixture branch from eddca9b to 61df9a8 Compare August 4, 2026 09:36
@gsxdsm
gsxdsm merged commit b00d8ad into Runfusion:main Aug 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants