Skip to content

Reverted back Luma Ray Settings control#316

Open
Sirsho1997 wants to merge 1 commit into
mainfrom
feature-revertback-luma-ray-changes
Open

Reverted back Luma Ray Settings control#316
Sirsho1997 wants to merge 1 commit into
mainfrom
feature-revertback-luma-ray-changes

Conversation

@Sirsho1997

Copy link
Copy Markdown
Collaborator

Changed

  • IVideoEditSettingsControls now uses flat fields for edit controls instead of nested per-control dataclasses:
    • poseStrength: Optional[str]
    • depthBlur: Optional[float]
    • normalsAugmentation: Optional[float]
    • trajectorySparsity: Optional[float]
    • face: Optional[bool]

Removed

  • Per-control video edit dataclasses superseded by the flat IVideoEditSettingsControls fields:
    • IVideoEditPoseControl
    • IVideoEditDepthControl
    • IVideoEditNormalsControl
    • IVideoEditTrajectoryControl
    • IVideoEditFaceControl

@Sirsho1997 Sirsho1997 requested a review from Copilot June 19, 2026 12:01
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a03ab74-d7e6-4aa2-8b46-d086aa266901

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature-revertback-luma-ray-changes

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the video edit “controls” typing/modeling in runware/types.py back to a flat-field representation on IVideoEditSettingsControls, removing the previously introduced per-control helper dataclasses and their dict→dataclass coercion.

Changes:

  • Removed nested per-control dataclasses (IVideoEditPoseControl, IVideoEditDepthControl, etc.).
  • Updated IVideoEditSettingsControls to use flat primitive fields (poseStrength, depthBlur, normalsAugmentation, trajectorySparsity, face).
  • Removed the per-field dict coercion previously performed in IVideoEditSettingsControls.__post_init__.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runware/types.py
Comment thread runware/types.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants